[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
blundell | 2102f7c | 2015-07-09 10:00:53 | [diff] [blame] | 5 | #include "components/omnibox/browser/zero_suggest_provider.h" |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 6 | |
avi | f57136c1 | 2015-12-25 23:27:45 | [diff] [blame] | 7 | #include <stddef.h> |
| 8 | |
Kevin Bailey | 1e2a90e | 2017-10-27 21:02:05 | [diff] [blame] | 9 | #include <string> |
| 10 | #include <utility> |
| 11 | |
Sebastien Marchand | 53801a3 | 2019-01-25 16:26:11 | [diff] [blame] | 12 | #include "base/bind.h" |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 13 | #include "base/callback.h" |
gcomanici | 8cabc77f | 2017-04-27 20:04:54 | [diff] [blame] | 14 | #include "base/feature_list.h" |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 15 | #include "base/i18n/case_conversion.h" |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 16 | #include "base/json/json_string_value_serializer.h" |
asvitkine | 3033081 | 2016-08-30 04:01:08 | [diff] [blame] | 17 | #include "base/metrics/histogram_macros.h" |
[email protected] | f7f41c0e | 2014-08-11 04:22:23 | [diff] [blame] | 18 | #include "base/metrics/user_metrics.h" |
Moe Ahmadi | 0993aec | 2019-09-19 21:42:30 | [diff] [blame] | 19 | #include "base/stl_util.h" |
[email protected] | 98570e1 | 2013-06-10 19:54:22 | [diff] [blame] | 20 | #include "base/strings/string16.h" |
| 21 | #include "base/strings/string_util.h" |
[email protected] | 135cb80 | 2013-06-09 16:44:20 | [diff] [blame] | 22 | #include "base/strings/utf_string_conversions.h" |
[email protected] | 4dcb797 | 2013-06-28 15:15:41 | [diff] [blame] | 23 | #include "base/time/time.h" |
a-v-y | dd768d5 | 2016-03-25 21:07:46 | [diff] [blame] | 24 | #include "base/trace_event/trace_event.h" |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 25 | #include "build/build_config.h" |
sdefresne | bc766ef | 2014-09-25 09:28:13 | [diff] [blame] | 26 | #include "components/history/core/browser/history_types.h" |
sdefresne | 0da3bc0 | 2015-01-29 18:26:35 | [diff] [blame] | 27 | #include "components/history/core/browser/top_sites.h" |
blundell | 2102f7c | 2015-07-09 10:00:53 | [diff] [blame] | 28 | #include "components/omnibox/browser/autocomplete_classifier.h" |
| 29 | #include "components/omnibox/browser/autocomplete_input.h" |
| 30 | #include "components/omnibox/browser/autocomplete_match.h" |
manuk | 3972b2f | 2019-04-19 14:22:56 | [diff] [blame] | 31 | #include "components/omnibox/browser/autocomplete_match_classification.h" |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 32 | #include "components/omnibox/browser/autocomplete_provider_client.h" |
blundell | 2102f7c | 2015-07-09 10:00:53 | [diff] [blame] | 33 | #include "components/omnibox/browser/autocomplete_provider_listener.h" |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 34 | #include "components/omnibox/browser/omnibox_field_trial.h" |
Moe Ahmadi | 1266de8 | 2020-04-10 17:19:53 | [diff] [blame] | 35 | #include "components/omnibox/browser/omnibox_prefs.h" |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 36 | #include "components/omnibox/browser/remote_suggestions_service.h" |
blundell | 2102f7c | 2015-07-09 10:00:53 | [diff] [blame] | 37 | #include "components/omnibox/browser/search_provider.h" |
Tommy Li | 823509e | 2019-12-06 22:42:47 | [diff] [blame] | 38 | #include "components/omnibox/browser/search_suggestion_parser.h" |
sdefresne | 70948d6 | 2015-08-11 10:46:35 | [diff] [blame] | 39 | #include "components/omnibox/browser/verbatim_match.h" |
Tomasz Wiszkowski | d938a111 | 2019-03-06 18:01:57 | [diff] [blame] | 40 | #include "components/omnibox/common/omnibox_features.h" |
[email protected] | f0c8c499 | 2014-05-15 17:37:26 | [diff] [blame] | 41 | #include "components/pref_registry/pref_registry_syncable.h" |
brettw | f00b9b4 | 2016-02-01 22:11:38 | [diff] [blame] | 42 | #include "components/prefs/pref_service.h" |
Tommy C. Li | 17b5ba11 | 2020-08-11 02:29:21 | [diff] [blame] | 43 | #include "components/search_engines/omnibox_focus_type.h" |
Gheorghe Comanici | 864725b | 2017-11-28 21:48:01 | [diff] [blame] | 44 | #include "components/search_engines/search_engine_type.h" |
[email protected] | bf5c532d | 2014-07-05 00:29:53 | [diff] [blame] | 45 | #include "components/search_engines/template_url_service.h" |
rsleevi | 24f64dc2 | 2015-08-07 21:39:21 | [diff] [blame] | 46 | #include "components/url_formatter/url_formatter.h" |
asvitkine | 9a27983 | 2015-12-18 02:35:50 | [diff] [blame] | 47 | #include "components/variations/net/variations_http_headers.h" |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 48 | #include "net/base/escape.h" |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 49 | #include "services/network/public/cpp/shared_url_loader_factory.h" |
| 50 | #include "services/network/public/cpp/simple_url_loader.h" |
Steven Holte | f9d5ed6 | 2017-10-21 02:02:30 | [diff] [blame] | 51 | #include "third_party/metrics_proto/omnibox_event.pb.h" |
| 52 | #include "third_party/metrics_proto/omnibox_input_type.pb.h" |
[email protected] | 761fa470 | 2013-07-02 15:25:15 | [diff] [blame] | 53 | #include "url/gurl.h" |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 54 | |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 55 | using metrics::OmniboxEventProto; |
| 56 | |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 57 | namespace { |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 58 | |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 59 | // Represents whether ZeroSuggestProvider is allowed to display contextual |
| 60 | // suggestions on focus, and if not, why not. |
| 61 | // These values are written to logs. New enum values can be added, but existing |
| 62 | // enums must never be renumbered or deleted and reused. |
| 63 | enum class ZeroSuggestEligibility { |
| 64 | ELIGIBLE = 0, |
| 65 | // URL_INELIGIBLE would be ELIGIBLE except some property of the current URL |
| 66 | // itself prevents ZeroSuggest from triggering. |
| 67 | URL_INELIGIBLE = 1, |
| 68 | GENERALLY_INELIGIBLE = 2, |
| 69 | ELIGIBLE_MAX_VALUE |
| 70 | }; |
| 71 | |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 72 | // TODO(hfung): The histogram code was copied and modified from |
| 73 | // search_provider.cc. Refactor and consolidate the code. |
| 74 | // We keep track in a histogram how many suggest requests we send, how |
| 75 | // many suggest requests we invalidate (e.g., due to a user typing |
| 76 | // another character), and how many replies we receive. |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 77 | // These values are written to logs. New enum values can be added, but existing |
| 78 | // enums must never be renumbered or deleted and reused. |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 79 | enum ZeroSuggestRequestsHistogramValue { |
| 80 | ZERO_SUGGEST_REQUEST_SENT = 1, |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 81 | ZERO_SUGGEST_REQUEST_INVALIDATED = 2, |
| 82 | ZERO_SUGGEST_REPLY_RECEIVED = 3, |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 83 | ZERO_SUGGEST_MAX_REQUEST_HISTOGRAM_VALUE |
| 84 | }; |
| 85 | |
| 86 | void LogOmniboxZeroSuggestRequest( |
| 87 | ZeroSuggestRequestsHistogramValue request_value) { |
| 88 | UMA_HISTOGRAM_ENUMERATION("Omnibox.ZeroSuggestRequests", request_value, |
| 89 | ZERO_SUGGEST_MAX_REQUEST_HISTOGRAM_VALUE); |
| 90 | } |
| 91 | |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 92 | // Relevance value to use if it was not set explicitly by the server. |
| 93 | const int kDefaultZeroSuggestRelevance = 100; |
Tomasz Wiszkowski | e23c56b | 2020-09-24 20:08:35 | [diff] [blame] | 94 | // The relevance score for navsuggest tiles. |
| 95 | // Navsuggest tiles should be positioned below the Query Tiles object. |
| 96 | const int kMostVisitedTilesRelevance = 1500; |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 97 | |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 98 | // Used for testing whether zero suggest is ever available. |
mpearson | c90c24b | 2017-03-04 00:11:26 | [diff] [blame] | 99 | constexpr char kArbitraryInsecureUrlString[] = "http://www.google.com/"; |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 100 | |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 101 | // Metric name tracking the omnibox suggestion eligibility. |
| 102 | constexpr char kOmniboxZeroSuggestEligibleHistogramName[] = |
| 103 | "Omnibox.ZeroSuggest.Eligible.OnFocusV2"; |
| 104 | |
Moe Ahmadi | 85bf7086 | 2019-10-11 00:03:32 | [diff] [blame] | 105 | // Remote suggestions are allowed only if the user is signed-in and has Google |
Moe Ahmadi | 189b653 | 2020-09-02 17:57:12 | [diff] [blame] | 106 | // set up as their default search engine. The authentication state check is done |
| 107 | // not for privacy reasons but to prevent signed-out users from querying the |
| 108 | // server which does not have any suggestions for them. This check is skipped if |
| 109 | // |check_authentication_state| is false. |
| 110 | // This function only applies to kRemoteNoUrlVariant. For kRemoteSendUrlVariant, |
| 111 | // most of these checks with the exception of the authentication state are done |
| 112 | // in BaseSearchProvider::CanSendURL(). |
Moe Ahmadi | 85bf7086 | 2019-10-11 00:03:32 | [diff] [blame] | 113 | bool RemoteNoUrlSuggestionsAreAllowed( |
Tomasz Wiszkowski | 5abea20 | 2019-06-06 22:51:14 | [diff] [blame] | 114 | AutocompleteProviderClient* client, |
Moe Ahmadi | 189b653 | 2020-09-02 17:57:12 | [diff] [blame] | 115 | const TemplateURLService* template_url_service, |
| 116 | bool check_authentication_state) { |
Tomasz Wiszkowski | 5abea20 | 2019-06-06 22:51:14 | [diff] [blame] | 117 | if (!client->SearchSuggestEnabled()) |
Moe Ahmadi | 85bf7086 | 2019-10-11 00:03:32 | [diff] [blame] | 118 | return false; |
Tomasz Wiszkowski | 5abea20 | 2019-06-06 22:51:14 | [diff] [blame] | 119 | |
Moe Ahmadi | 189b653 | 2020-09-02 17:57:12 | [diff] [blame] | 120 | if (check_authentication_state && !client->IsAuthenticated()) |
Moe Ahmadi | 85bf7086 | 2019-10-11 00:03:32 | [diff] [blame] | 121 | return false; |
Gheorghe Comanici | 864725b | 2017-11-28 21:48:01 | [diff] [blame] | 122 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 123 | if (template_url_service == nullptr) |
| 124 | return false; |
Gheorghe Comanici | 68250410 | 2017-11-30 17:47:25 | [diff] [blame] | 125 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 126 | const TemplateURL* default_provider = |
| 127 | template_url_service->GetDefaultSearchProvider(); |
Moe Ahmadi | 85bf7086 | 2019-10-11 00:03:32 | [diff] [blame] | 128 | return default_provider && |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 129 | default_provider->GetEngineType( |
Moe Ahmadi | 85bf7086 | 2019-10-11 00:03:32 | [diff] [blame] | 130 | template_url_service->search_terms_data()) == SEARCH_ENGINE_GOOGLE; |
Gheorghe Comanici | 864725b | 2017-11-28 21:48:01 | [diff] [blame] | 131 | } |
| 132 | |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 133 | } // namespace |
| 134 | |
[email protected] | a00008d4 | 2012-09-15 05:07:58 | [diff] [blame] | 135 | // static |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 136 | const char ZeroSuggestProvider::kNoneVariant[] = "None"; |
| 137 | const char ZeroSuggestProvider::kRemoteNoUrlVariant[] = "RemoteNoUrl"; |
| 138 | const char ZeroSuggestProvider::kRemoteSendUrlVariant[] = "RemoteSendUrl"; |
| 139 | const char ZeroSuggestProvider::kMostVisitedVariant[] = "MostVisited"; |
| 140 | |
| 141 | // static |
[email protected] | a00008d4 | 2012-09-15 05:07:58 | [diff] [blame] | 142 | ZeroSuggestProvider* ZeroSuggestProvider::Create( |
blundell | 55e35e8 | 2015-06-16 08:46:18 | [diff] [blame] | 143 | AutocompleteProviderClient* client, |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 144 | AutocompleteProviderListener* listener) { |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 145 | return new ZeroSuggestProvider(client, listener); |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 146 | } |
| 147 | |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 148 | // static |
Moe Ahmadi | 1266de8 | 2020-04-10 17:19:53 | [diff] [blame] | 149 | void ZeroSuggestProvider::RegisterProfilePrefs(PrefRegistrySimple* registry) { |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 150 | registry->RegisterStringPref(omnibox::kZeroSuggestCachedResults, |
| 151 | std::string()); |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 152 | } |
| 153 | |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 154 | void ZeroSuggestProvider::Start(const AutocompleteInput& input, |
jif | cf322cd | 2015-06-17 11:01:18 | [diff] [blame] | 155 | bool minimal_changes) { |
a-v-y | dd768d5 | 2016-03-25 21:07:46 | [diff] [blame] | 156 | TRACE_EVENT0("omnibox", "ZeroSuggestProvider::Start"); |
[email protected] | f030c4d | 2014-03-25 01:05:54 | [diff] [blame] | 157 | matches_.clear(); |
Kevin Bailey | 8642e61 | 2018-04-23 20:27:54 | [diff] [blame] | 158 | Stop(true, false); |
Jenny Zhang | 5bc2e3d | 2018-09-10 18:50:55 | [diff] [blame] | 159 | |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 160 | if (!AllowZeroSuggestSuggestions(input)) { |
| 161 | UMA_HISTOGRAM_ENUMERATION(kOmniboxZeroSuggestEligibleHistogramName, |
| 162 | ZeroSuggestEligibility::GENERALLY_INELIGIBLE, |
| 163 | ZeroSuggestEligibility::ELIGIBLE_MAX_VALUE); |
[email protected] | f030c4d | 2014-03-25 01:05:54 | [diff] [blame] | 164 | return; |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 165 | } |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 166 | |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 167 | result_type_running_ = NONE; |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 168 | set_field_trial_triggered(false); |
| 169 | set_field_trial_triggered_in_session(false); |
[email protected] | f030c4d | 2014-03-25 01:05:54 | [diff] [blame] | 170 | permanent_text_ = input.text(); |
| 171 | current_query_ = input.current_url().spec(); |
gcomanici | 8cabc77f | 2017-04-27 20:04:54 | [diff] [blame] | 172 | current_title_ = input.current_title(); |
Tommy Li | c53b97e | 2020-09-03 04:02:40 | [diff] [blame] | 173 | current_page_classification_ = input.current_page_classification(); |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 174 | current_text_match_ = MatchForCurrentText(); |
[email protected] | 9b9fa67 | 2013-11-07 06:04:52 | [diff] [blame] | 175 | |
Tommy C. Li | 6aee62d5 | 2019-06-27 20:25:00 | [diff] [blame] | 176 | TemplateURLRef::SearchTermsArgs search_terms_args; |
| 177 | search_terms_args.page_classification = current_page_classification_; |
Tommy Li | 4b7c418 | 2020-08-18 19:37:01 | [diff] [blame] | 178 | search_terms_args.focus_type = input.focus_type(); |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 179 | GURL suggest_url = RemoteSuggestionsService::EndpointUrl( |
Tommy C. Li | 6aee62d5 | 2019-06-27 20:25:00 | [diff] [blame] | 180 | search_terms_args, client()->GetTemplateURLService()); |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 181 | if (!suggest_url.is_valid()) |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 182 | return; |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 183 | |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 184 | result_type_running_ = TypeOfResultToRun(client(), input, suggest_url); |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 185 | if (result_type_running_ == NONE) |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 186 | return; |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 187 | |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 188 | done_ = false; |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 189 | |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 190 | MaybeUseCachedSuggestions(); |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 191 | |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 192 | if (result_type_running_ == MOST_VISITED) { |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 193 | most_visited_urls_.clear(); |
| 194 | scoped_refptr<history::TopSites> ts = client()->GetTopSites(); |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 195 | if (!ts) { |
| 196 | done_ = true; |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 197 | result_type_running_ = NONE; |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 198 | return; |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 199 | } |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 200 | |
Kevin Bailey | 40bb0ac5 | 2019-04-02 00:43:32 | [diff] [blame] | 201 | ts->GetMostVisitedURLs(base::BindRepeating( |
| 202 | &ZeroSuggestProvider::OnMostVisitedUrlsAvailable, |
| 203 | weak_ptr_factory_.GetWeakPtr(), most_visited_request_num_)); |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 204 | return; |
| 205 | } |
| 206 | |
Tommy C. Li | 6aee62d5 | 2019-06-27 20:25:00 | [diff] [blame] | 207 | search_terms_args.current_page_url = |
Tommy C. Li | d77691a | 2019-06-05 02:07:46 | [diff] [blame] | 208 | result_type_running_ == REMOTE_SEND_URL ? current_query_ : std::string(); |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 209 | // Create a request for suggestions, routing completion to |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 210 | // OnRemoteSuggestionsLoaderAvailable. |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 211 | client() |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 212 | ->GetRemoteSuggestionsService(/*create_if_necessary=*/true) |
| 213 | ->CreateSuggestionsRequest( |
Tommy Li | 3fe8391 | 2019-08-23 17:33:11 | [diff] [blame] | 214 | search_terms_args, client()->GetTemplateURLService(), |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 215 | base::BindOnce( |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 216 | &ZeroSuggestProvider::OnRemoteSuggestionsLoaderAvailable, |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 217 | weak_ptr_factory_.GetWeakPtr()), |
| 218 | base::BindOnce( |
| 219 | &ZeroSuggestProvider::OnURLLoadComplete, |
| 220 | base::Unretained(this) /* this owns SimpleURLLoader */)); |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 221 | } |
| 222 | |
mpearson | 8a37c38 | 2015-03-07 05:58:57 | [diff] [blame] | 223 | void ZeroSuggestProvider::Stop(bool clear_cached_results, |
| 224 | bool due_to_user_inactivity) { |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 225 | if (loader_) |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 226 | LogOmniboxZeroSuggestRequest(ZERO_SUGGEST_REQUEST_INVALIDATED); |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 227 | loader_.reset(); |
Tommy Li | 3fe8391 | 2019-08-23 17:33:11 | [diff] [blame] | 228 | |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 229 | // TODO(krb): It would allow us to remove some guards if we could also cancel |
| 230 | // the TopSites::GetMostVisitedURLs request. |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 231 | done_ = true; |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 232 | result_type_running_ = NONE; |
| 233 | ++most_visited_request_num_; |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 234 | |
| 235 | if (clear_cached_results) { |
| 236 | // We do not call Clear() on |results_| to retain |verbatim_relevance| |
| 237 | // value in the |results_| object. |verbatim_relevance| is used at the |
jif | cf322cd | 2015-06-17 11:01:18 | [diff] [blame] | 238 | // beginning of the next call to Start() to determine the current url |
| 239 | // match relevance. |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 240 | results_.suggest_results.clear(); |
| 241 | results_.navigation_results.clear(); |
Moe Ahmadi | b8a1daf | 2020-02-14 22:23:25 | [diff] [blame] | 242 | results_.experiment_stats.clear(); |
Moe Ahmadi | d2704a7a | 2020-03-31 22:04:26 | [diff] [blame] | 243 | results_.headers_map.clear(); |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 244 | current_query_.clear(); |
gcomanici | 8cabc77f | 2017-04-27 20:04:54 | [diff] [blame] | 245 | current_title_.clear(); |
mariakhomenko | 1535e6a | 2015-03-20 07:48:45 | [diff] [blame] | 246 | most_visited_urls_.clear(); |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 247 | } |
| 248 | } |
| 249 | |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 250 | void ZeroSuggestProvider::DeleteMatch(const AutocompleteMatch& match) { |
Moe Ahmadi | 0993aec | 2019-09-19 21:42:30 | [diff] [blame] | 251 | if (base::Contains(OmniboxFieldTrial::GetZeroSuggestVariants( |
| 252 | current_page_classification_), |
| 253 | kRemoteNoUrlVariant)) { |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 254 | // Remove the deleted match from the cache, so it is not shown to the user |
| 255 | // again. Since we cannot remove just one result, blow away the cache. |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 256 | client()->GetPrefs()->SetString(omnibox::kZeroSuggestCachedResults, |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 257 | std::string()); |
| 258 | } |
| 259 | BaseSearchProvider::DeleteMatch(match); |
| 260 | } |
| 261 | |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 262 | void ZeroSuggestProvider::AddProviderInfo(ProvidersInfo* provider_info) const { |
| 263 | BaseSearchProvider::AddProviderInfo(provider_info); |
mariakhomenko | 1535e6a | 2015-03-20 07:48:45 | [diff] [blame] | 264 | if (!results_.suggest_results.empty() || |
| 265 | !results_.navigation_results.empty() || |
| 266 | !most_visited_urls_.empty()) |
[email protected] | ec3f679b | 2014-08-18 07:45:13 | [diff] [blame] | 267 | provider_info->back().set_times_returned_results_in_session(1); |
| 268 | } |
| 269 | |
[email protected] | f030c4d | 2014-03-25 01:05:54 | [diff] [blame] | 270 | void ZeroSuggestProvider::ResetSession() { |
| 271 | // The user has started editing in the omnibox, so leave |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 272 | // |field_trial_triggered_in_session| unchanged and set |
| 273 | // |field_trial_triggered| to false since zero suggest is inactive now. |
| 274 | set_field_trial_triggered(false); |
[email protected] | f030c4d | 2014-03-25 01:05:54 | [diff] [blame] | 275 | } |
| 276 | |
mpearson | 931028c | 2016-07-01 18:55:11 | [diff] [blame] | 277 | ZeroSuggestProvider::ZeroSuggestProvider( |
| 278 | AutocompleteProviderClient* client, |
mpearson | 931028c | 2016-07-01 18:55:11 | [diff] [blame] | 279 | AutocompleteProviderListener* listener) |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 280 | : BaseSearchProvider(AutocompleteProvider::TYPE_ZERO_SUGGEST, client), |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 281 | listener_(listener), |
Jeremy Roman | 5c341f6d | 2019-07-15 15:56:10 | [diff] [blame] | 282 | result_type_running_(NONE) { |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 283 | // Record whether remote zero suggest is possible for this user / profile. |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 284 | const TemplateURLService* template_url_service = |
| 285 | client->GetTemplateURLService(); |
| 286 | // Template URL service can be null in tests. |
| 287 | if (template_url_service != nullptr) { |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 288 | GURL suggest_url = RemoteSuggestionsService::EndpointUrl( |
Tommy C. Li | 6aee62d5 | 2019-06-27 20:25:00 | [diff] [blame] | 289 | TemplateURLRef::SearchTermsArgs(), template_url_service); |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 290 | // To check whether this is allowed, use an arbitrary insecure (http) URL |
| 291 | // as the URL we'd want suggestions for. The value of OTHER as the current |
| 292 | // page classification is to correspond with that URL. |
| 293 | UMA_HISTOGRAM_BOOLEAN( |
| 294 | "Omnibox.ZeroSuggest.Eligible.OnProfileOpen", |
| 295 | suggest_url.is_valid() && |
| 296 | CanSendURL(GURL(kArbitraryInsecureUrlString), suggest_url, |
| 297 | template_url_service->GetDefaultSearchProvider(), |
| 298 | metrics::OmniboxEventProto::OTHER, |
Tommy C. Li | 71171ee | 2019-06-20 17:11:47 | [diff] [blame] | 299 | template_url_service->search_terms_data(), client, |
| 300 | false)); |
mpearson | 3d89cdc | 2017-03-03 21:15:45 | [diff] [blame] | 301 | } |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 302 | } |
| 303 | |
Tomasz Wiszkowski | f2464a8 | 2020-02-18 22:42:25 | [diff] [blame] | 304 | ZeroSuggestProvider::~ZeroSuggestProvider() = default; |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 305 | |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 306 | const TemplateURL* ZeroSuggestProvider::GetTemplateURL(bool is_keyword) const { |
| 307 | // Zero suggest provider should not receive keyword results. |
| 308 | DCHECK(!is_keyword); |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 309 | return client()->GetTemplateURLService()->GetDefaultSearchProvider(); |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 310 | } |
| 311 | |
| 312 | const AutocompleteInput ZeroSuggestProvider::GetInput(bool is_keyword) const { |
jif | cf322cd | 2015-06-17 11:01:18 | [diff] [blame] | 313 | // The callers of this method won't look at the AutocompleteInput's |
| 314 | // |from_omnibox_focus| member, so we can set its value to false. |
Kevin Bailey | bcc319e | 2017-10-01 21:53:02 | [diff] [blame] | 315 | AutocompleteInput input(base::string16(), current_page_classification_, |
| 316 | client()->GetSchemeClassifier()); |
| 317 | input.set_current_url(GURL(current_query_)); |
| 318 | input.set_current_title(current_title_); |
| 319 | input.set_prevent_inline_autocomplete(true); |
| 320 | input.set_allow_exact_keyword_match(false); |
| 321 | return input; |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 322 | } |
| 323 | |
| 324 | bool ZeroSuggestProvider::ShouldAppendExtraParams( |
| 325 | const SearchSuggestionParser::SuggestResult& result) const { |
| 326 | // We always use the default provider for search, so append the params. |
| 327 | return true; |
| 328 | } |
| 329 | |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 330 | void ZeroSuggestProvider::RecordDeletionResult(bool success) { |
| 331 | if (success) { |
| 332 | base::RecordAction( |
| 333 | base::UserMetricsAction("Omnibox.ZeroSuggestDelete.Success")); |
| 334 | } else { |
| 335 | base::RecordAction( |
| 336 | base::UserMetricsAction("Omnibox.ZeroSuggestDelete.Failure")); |
| 337 | } |
| 338 | } |
| 339 | |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 340 | void ZeroSuggestProvider::OnURLLoadComplete( |
| 341 | const network::SimpleURLLoader* source, |
| 342 | std::unique_ptr<std::string> response_body) { |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 343 | DCHECK(!done_); |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 344 | DCHECK_EQ(loader_.get(), source); |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 345 | |
| 346 | LogOmniboxZeroSuggestRequest(ZERO_SUGGEST_REPLY_RECEIVED); |
| 347 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 348 | const bool results_updated = |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 349 | response_body && source->NetError() == net::OK && |
| 350 | (source->ResponseInfo() && source->ResponseInfo()->headers && |
| 351 | source->ResponseInfo()->headers->response_code() == 200) && |
| 352 | UpdateResults(SearchSuggestionParser::ExtractJsonData( |
| 353 | source, std::move(response_body))); |
| 354 | loader_.reset(); |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 355 | done_ = true; |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 356 | result_type_running_ = NONE; |
| 357 | ++most_visited_request_num_; |
[email protected] | 776ee590 | 2014-08-11 09:15:19 | [diff] [blame] | 358 | listener_->OnProviderUpdate(results_updated); |
| 359 | } |
| 360 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 361 | bool ZeroSuggestProvider::UpdateResults(const std::string& json_data) { |
| 362 | std::unique_ptr<base::Value> data( |
| 363 | SearchSuggestionParser::DeserializeJsonData(json_data)); |
| 364 | if (!data) |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 365 | return false; |
| 366 | |
Tommy C. Li | 467c1bcaa | 2019-06-20 20:48:05 | [diff] [blame] | 367 | // When running the REMOTE_NO_URL variant, we want to store suggestion |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 368 | // responses if non-empty. |
Tommy C. Li | d77691a | 2019-06-05 02:07:46 | [diff] [blame] | 369 | if (result_type_running_ == REMOTE_NO_URL && !json_data.empty()) { |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 370 | client()->GetPrefs()->SetString(omnibox::kZeroSuggestCachedResults, |
| 371 | json_data); |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 372 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 373 | // If we received an empty result list, we should update the display, as it |
| 374 | // may be showing cached results that should not be shown. |
| 375 | const base::ListValue* root_list = nullptr; |
| 376 | const base::ListValue* results_list = nullptr; |
| 377 | const bool non_empty_parsed_list = data->GetAsList(&root_list) && |
| 378 | root_list->GetList(1, &results_list) && |
| 379 | !results_list->empty(); |
| 380 | const bool non_empty_cache = !results_.suggest_results.empty() || |
| 381 | !results_.navigation_results.empty(); |
| 382 | if (non_empty_parsed_list && non_empty_cache) |
| 383 | return false; |
| 384 | } |
| 385 | const bool results_updated = ParseSuggestResults( |
| 386 | *data, kDefaultZeroSuggestRelevance, false, &results_); |
| 387 | ConvertResultsToAutocompleteMatches(); |
| 388 | return results_updated; |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 389 | } |
| 390 | |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 391 | AutocompleteMatch ZeroSuggestProvider::NavigationToMatch( |
[email protected] | 0b9575f | 2014-07-30 11:58:37 | [diff] [blame] | 392 | const SearchSuggestionParser::NavigationResult& navigation) { |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 393 | AutocompleteMatch match(this, navigation.relevance(), false, |
[email protected] | 78981d8c | 2014-05-09 15:05:47 | [diff] [blame] | 394 | navigation.type()); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 395 | match.destination_url = navigation.url(); |
| 396 | |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 397 | match.fill_into_edit += |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 398 | AutocompleteInput::FormattedStringWithEquivalentMeaning( |
Tommy C. Li | 0beb815 | 2017-08-25 18:30:26 | [diff] [blame] | 399 | navigation.url(), url_formatter::FormatUrl(navigation.url()), |
Kevin Bailey | 83e643d | 2018-03-08 16:01:41 | [diff] [blame] | 400 | client()->GetSchemeClassifier(), nullptr); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 401 | |
manuk | 3972b2f | 2019-04-19 14:22:56 | [diff] [blame] | 402 | // Zero suggest results should always omit protocols and never appear bold. |
| 403 | auto format_types = AutocompleteMatch::GetFormatTypes(false, false); |
| 404 | match.contents = url_formatter::FormatUrl(navigation.url(), format_types, |
| 405 | net::UnescapeRule::SPACES, nullptr, |
| 406 | nullptr, nullptr); |
| 407 | match.contents_class = ClassifyTermMatches({}, match.contents.length(), 0, |
| 408 | ACMatchClassification::URL); |
[email protected] | 9c97f89c | 2013-06-25 03:12:16 | [diff] [blame] | 409 | |
| 410 | match.description = |
| 411 | AutocompleteMatch::SanitizeString(navigation.description()); |
manuk | 3972b2f | 2019-04-19 14:22:56 | [diff] [blame] | 412 | match.description_class = ClassifyTermMatches({}, match.description.length(), |
| 413 | 0, ACMatchClassification::NONE); |
| 414 | |
Tomasz Wiszkowski | afe090f | 2020-07-10 22:45:36 | [diff] [blame] | 415 | match.subtypes = navigation.subtypes(); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 416 | return match; |
| 417 | } |
| 418 | |
[email protected] | 8f064e5 | 2013-09-18 01:17:14 | [diff] [blame] | 419 | void ZeroSuggestProvider::OnMostVisitedUrlsAvailable( |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 420 | size_t orig_request_num, |
[email protected] | 8f064e5 | 2013-09-18 01:17:14 | [diff] [blame] | 421 | const history::MostVisitedURLList& urls) { |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 422 | if (result_type_running_ != MOST_VISITED || |
| 423 | orig_request_num != most_visited_request_num_) { |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 424 | return; |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 425 | } |
[email protected] | 8f064e5 | 2013-09-18 01:17:14 | [diff] [blame] | 426 | most_visited_urls_ = urls; |
mariakhomenko | bfc3a2a | 2014-10-24 00:48:22 | [diff] [blame] | 427 | done_ = true; |
| 428 | ConvertResultsToAutocompleteMatches(); |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 429 | result_type_running_ = NONE; |
| 430 | ++most_visited_request_num_; |
mariakhomenko | bfc3a2a | 2014-10-24 00:48:22 | [diff] [blame] | 431 | listener_->OnProviderUpdate(true); |
[email protected] | 8f064e5 | 2013-09-18 01:17:14 | [diff] [blame] | 432 | } |
| 433 | |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 434 | void ZeroSuggestProvider::OnRemoteSuggestionsLoaderAvailable( |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 435 | std::unique_ptr<network::SimpleURLLoader> loader) { |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 436 | // RemoteSuggestionsService has already started |loader|, so here it's |
Darwin Huang | 663c17d | 2020-02-06 01:10:01 | [diff] [blame] | 437 | // only necessary to grab its ownership until results come in to |
Maks Orlovich | 1b20851 | 2018-06-13 21:08:17 | [diff] [blame] | 438 | // OnURLLoadComplete(). |
| 439 | loader_ = std::move(loader); |
Daniel Kenji Toyama | f1e4b57 | 2017-08-03 16:31:11 | [diff] [blame] | 440 | LogOmniboxZeroSuggestRequest(ZERO_SUGGEST_REQUEST_SENT); |
| 441 | } |
| 442 | |
[email protected] | 9c97f89c | 2013-06-25 03:12:16 | [diff] [blame] | 443 | void ZeroSuggestProvider::ConvertResultsToAutocompleteMatches() { |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 444 | matches_.clear(); |
| 445 | |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 446 | TemplateURLService* template_url_service = client()->GetTemplateURLService(); |
Kevin Bailey | 9bdd15d | 2018-02-28 04:07:49 | [diff] [blame] | 447 | DCHECK(template_url_service); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 448 | const TemplateURL* default_provider = |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 449 | template_url_service->GetDefaultSearchProvider(); |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 450 | // Fail if we can't set the clickthrough URL for query suggestions. |
Ivan Kotenkov | 75b1c3a | 2017-10-24 14:47:24 | [diff] [blame] | 451 | if (default_provider == nullptr || |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 452 | !default_provider->SupportsReplacement( |
| 453 | template_url_service->search_terms_data())) |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 454 | return; |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 455 | |
[email protected] | 0040474 | 2014-02-20 13:09:05 | [diff] [blame] | 456 | MatchMap map; |
Tommy Li | 823509e | 2019-12-06 22:42:47 | [diff] [blame] | 457 | |
Tommy C. Li | 167a368 | 2020-07-16 19:47:23 | [diff] [blame] | 458 | // Add all the SuggestResults to the map. We display all ZeroSuggest search |
| 459 | // suggestions as unbolded. |
Tommy Li | 823509e | 2019-12-06 22:42:47 | [diff] [blame] | 460 | for (size_t i = 0; i < results_.suggest_results.size(); ++i) { |
Tommy Li | 823509e | 2019-12-06 22:42:47 | [diff] [blame] | 461 | AddMatchToMap(results_.suggest_results[i], std::string(), i, false, false, |
| 462 | &map); |
| 463 | } |
[email protected] | 0040474 | 2014-02-20 13:09:05 | [diff] [blame] | 464 | |
| 465 | const int num_query_results = map.size(); |
| 466 | const int num_nav_results = results_.navigation_results.size(); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 467 | const int num_results = num_query_results + num_nav_results; |
Steven Holte | 9592222 | 2018-09-14 20:06:23 | [diff] [blame] | 468 | UMA_HISTOGRAM_COUNTS_1M("ZeroSuggest.QueryResults", num_query_results); |
| 469 | UMA_HISTOGRAM_COUNTS_1M("ZeroSuggest.URLResults", num_nav_results); |
| 470 | UMA_HISTOGRAM_COUNTS_1M("ZeroSuggest.AllResults", num_results); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 471 | |
[email protected] | 8f064e5 | 2013-09-18 01:17:14 | [diff] [blame] | 472 | // Show Most Visited results after ZeroSuggest response is received. |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 473 | if (result_type_running_ == MOST_VISITED) { |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 474 | // Ensure we don't show most visited URL suggestions on NTP. |
| 475 | // This allows us to prevent undesired side outcome of presenting |
| 476 | // URL suggestions to users who are not in the personalized field trial for |
| 477 | // zero query suggestions. |
| 478 | if (IsNTPPage(current_page_classification_) || |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 479 | !current_text_match_.destination_url.is_valid()) { |
[email protected] | 3feb8b00 | 2013-10-14 23:50:13 | [diff] [blame] | 480 | return; |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 481 | } |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 482 | matches_.push_back(current_text_match_); |
Tomasz Wiszkowski | e23c56b | 2020-09-24 20:08:35 | [diff] [blame] | 483 | |
| 484 | // Short-circuit in case we have no MOST_VISITED urls to show. |
| 485 | if (most_visited_urls_.empty()) |
| 486 | return; |
| 487 | |
| 488 | if (base::FeatureList::IsEnabled(omnibox::kMostVisitedTiles)) { |
| 489 | AutocompleteMatch match = |
| 490 | NavigationToMatch(SearchSuggestionParser::NavigationResult( |
| 491 | client()->GetSchemeClassifier(), GURL::EmptyGURL(), |
| 492 | AutocompleteMatchType::TILE_NAVSUGGEST, {}, base::string16(), |
| 493 | std::string(), false, kMostVisitedTilesRelevance, true, |
| 494 | base::ASCIIToUTF16(current_query_))); |
| 495 | match.navsuggest_tiles.reserve(most_visited_urls_.size()); |
| 496 | |
| 497 | for (const auto& url : most_visited_urls_) { |
| 498 | match.navsuggest_tiles.push_back({url.url, url.title}); |
| 499 | } |
| 500 | matches_.push_back(std::move(match)); |
| 501 | } else { |
| 502 | int relevance = 600; |
| 503 | for (const auto& url : most_visited_urls_) { |
| 504 | SearchSuggestionParser::NavigationResult nav( |
| 505 | client()->GetSchemeClassifier(), url.url, |
| 506 | AutocompleteMatchType::NAVSUGGEST, {}, url.title, std::string(), |
| 507 | false, relevance, true, base::ASCIIToUTF16(current_query_)); |
| 508 | matches_.push_back(NavigationToMatch(nav)); |
| 509 | --relevance; |
| 510 | } |
[email protected] | 8f064e5 | 2013-09-18 01:17:14 | [diff] [blame] | 511 | } |
| 512 | return; |
| 513 | } |
| 514 | |
[email protected] | 9c97f89c | 2013-06-25 03:12:16 | [diff] [blame] | 515 | if (num_results == 0) |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 516 | return; |
| 517 | |
Tommy Li | 0731aee | 2020-07-22 23:04:32 | [diff] [blame] | 518 | #if defined(OS_ANDROID) || defined(OS_IOS) |
| 519 | // Android needs the verbatim match on non-NTP surfaces to properly present |
| 520 | // the Search Ready Omnibox URL edit widget. Desktop specifically does NOT |
| 521 | // want to show verbatim matches in remotely-fetched ZeroSuggest anymore. |
| 522 | // iOS we are keeping the same as Android for now. No strong reason to change. |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 523 | if (!IsNTPPage(current_page_classification_) && |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 524 | current_text_match_.destination_url.is_valid()) { |
| 525 | matches_.push_back(current_text_match_); |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 526 | } |
Tommy Li | 0731aee | 2020-07-22 23:04:32 | [diff] [blame] | 527 | #endif |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 528 | |
[email protected] | 0040474 | 2014-02-20 13:09:05 | [diff] [blame] | 529 | for (MatchMap::const_iterator it(map.begin()); it != map.end(); ++it) |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 530 | matches_.push_back(it->second); |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 531 | |
[email protected] | 0b9575f | 2014-07-30 11:58:37 | [diff] [blame] | 532 | const SearchSuggestionParser::NavigationResults& nav_results( |
| 533 | results_.navigation_results); |
Tomasz Wiszkowski | f2464a8 | 2020-02-18 22:42:25 | [diff] [blame] | 534 | for (const auto& nav_result : nav_results) { |
| 535 | matches_.push_back(NavigationToMatch(nav_result)); |
gcomanici | 67d53ac | 2017-04-01 17:07:19 | [diff] [blame] | 536 | } |
[email protected] | 6ce7f61 | 2012-09-05 23:53:07 | [diff] [blame] | 537 | } |
| 538 | |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 539 | AutocompleteMatch ZeroSuggestProvider::MatchForCurrentText() { |
[email protected] | bb1fb2b | 2013-05-31 00:21:01 | [diff] [blame] | 540 | // The placeholder suggestion for the current URL has high relevance so |
| 541 | // that it is in the first suggestion slot and inline autocompleted. It |
| 542 | // gets dropped as soon as the user types something. |
mpearson | 931028c | 2016-07-01 18:55:11 | [diff] [blame] | 543 | AutocompleteInput tmp(GetInput(false)); |
| 544 | tmp.UpdateText(permanent_text_, base::string16::npos, tmp.parts()); |
gcomanici | 8cabc77f | 2017-04-27 20:04:54 | [diff] [blame] | 545 | const base::string16 description = |
| 546 | (base::FeatureList::IsEnabled(omnibox::kDisplayTitleForCurrentUrl)) |
| 547 | ? current_title_ |
| 548 | : base::string16(); |
Tommy Li | ec99def | 2019-10-14 22:37:23 | [diff] [blame] | 549 | |
| 550 | // We pass a nullptr as the |history_url_provider| parameter now to force |
| 551 | // VerbatimMatch to do a classification, since the text can be a search query. |
| 552 | // TODO(tommycli): Simplify this - probably just bypass VerbatimMatchForURL. |
| 553 | AutocompleteMatch match = VerbatimMatchForURL( |
| 554 | client(), tmp, GURL(current_query_), description, |
| 555 | /*history_url_provider=*/nullptr, results_.verbatim_relevance); |
| 556 | match.provider = this; |
| 557 | return match; |
[email protected] | 0040474 | 2014-02-20 13:09:05 | [diff] [blame] | 558 | } |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 559 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 560 | bool ZeroSuggestProvider::AllowZeroSuggestSuggestions( |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 561 | const AutocompleteInput& input) const { |
| 562 | const auto& page_url = input.current_url(); |
| 563 | const auto page_class = input.current_page_classification(); |
| 564 | const auto input_type = input.type(); |
Peter Kasting | fb1a8ea | 2017-11-28 02:26:50 | [diff] [blame] | 565 | |
Tommy C. Li | 17b5ba11 | 2020-08-11 02:29:21 | [diff] [blame] | 566 | if (input.focus_type() == OmniboxFocusType::DEFAULT) |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 567 | return false; |
| 568 | |
Tommy Li | 8bc9cd6 | 2020-08-18 02:37:28 | [diff] [blame] | 569 | if (client()->IsOffTheRecord()) |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 570 | return false; |
| 571 | |
Tommy Li | 19e27ede | 2020-08-14 22:52:40 | [diff] [blame] | 572 | if (input_type == metrics::OmniboxInputType::EMPTY) { |
| 573 | // Function that returns whether EMPTY input zero-suggest is allowed. |
| 574 | auto IsEmptyZeroSuggestAllowed = [&]() { |
| 575 | if (page_class == metrics::OmniboxEventProto::CHROMEOS_APP_LIST || |
| 576 | IsNTPPage(page_class)) { |
| 577 | return true; |
| 578 | } |
| 579 | |
| 580 | if (page_class == metrics::OmniboxEventProto::OTHER) { |
| 581 | return input.focus_type() == OmniboxFocusType::DELETED_PERMANENT_TEXT && |
| 582 | base::FeatureList::IsEnabled( |
| 583 | omnibox::kClobberTriggersContextualWebZeroSuggest); |
| 584 | } |
| 585 | |
| 586 | return false; |
| 587 | }; |
| 588 | |
| 589 | // Return false if disallowed. Otherwise, proceed down to further checks. |
| 590 | if (!IsEmptyZeroSuggestAllowed()) |
| 591 | return false; |
[email protected] | 5b899dc | 2018-10-02 09:20:01 | [diff] [blame] | 592 | } |
| 593 | |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 594 | // When omnibox contains pre-populated content, only show zero suggest for |
| 595 | // pages with URLs the user will recognize. |
| 596 | // |
Mark Pearson | 3fb0e316 | 2018-08-27 21:53:57 | [diff] [blame] | 597 | // This list intentionally does not include items such as ftp: and file: |
Tommy C. Li | 06ec26a | 2019-06-10 18:01:42 | [diff] [blame] | 598 | // because (a) these do not work on Android and iOS, where most visited |
Mark Pearson | 3fb0e316 | 2018-08-27 21:53:57 | [diff] [blame] | 599 | // zero suggest is launched and (b) on desktop, where contextual zero suggest |
| 600 | // is running, these types of schemes aren't eligible to be sent to the |
| 601 | // server to ask for suggestions (and thus in practice we won't display zero |
| 602 | // suggest for them). |
Yue Ru Sun | e31e157 | 2019-07-19 17:09:57 | [diff] [blame] | 603 | if (input_type != metrics::OmniboxInputType::EMPTY && |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 604 | !(page_url.is_valid() && |
| 605 | ((page_url.scheme() == url::kHttpScheme) || |
| 606 | (page_url.scheme() == url::kHttpsScheme) || |
| 607 | (page_url.scheme() == url::kAboutScheme) || |
| 608 | (page_url.scheme() == |
| 609 | client()->GetEmbedderRepresentationOfAboutScheme())))) { |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 610 | return false; |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 611 | } |
[email protected] | 162c8d9fa | 2014-03-18 20:25:41 | [diff] [blame] | 612 | |
| 613 | return true; |
| 614 | } |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 615 | |
| 616 | void ZeroSuggestProvider::MaybeUseCachedSuggestions() { |
Tommy C. Li | d77691a | 2019-06-05 02:07:46 | [diff] [blame] | 617 | if (result_type_running_ != REMOTE_NO_URL) |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 618 | return; |
| 619 | |
blundell | d130d59 | 2015-06-21 19:29:13 | [diff] [blame] | 620 | std::string json_data = |
| 621 | client()->GetPrefs()->GetString(omnibox::kZeroSuggestCachedResults); |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 622 | if (!json_data.empty()) { |
dcheng | 259570c | 2016-04-22 00:45:57 | [diff] [blame] | 623 | std::unique_ptr<base::Value> data( |
[email protected] | 2c802d1 | 2014-07-31 12:57:14 | [diff] [blame] | 624 | SearchSuggestionParser::DeserializeJsonData(json_data)); |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 625 | if (data && ParseSuggestResults(*data, kDefaultZeroSuggestRelevance, false, |
| 626 | &results_)) |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 627 | ConvertResultsToAutocompleteMatches(); |
[email protected] | 855ebff | 2014-05-09 07:14:38 | [diff] [blame] | 628 | } |
| 629 | } |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 630 | |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 631 | // static |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 632 | ZeroSuggestProvider::ResultType ZeroSuggestProvider::TypeOfResultToRun( |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 633 | AutocompleteProviderClient* client, |
| 634 | const AutocompleteInput& input, |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 635 | const GURL& suggest_url) { |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 636 | DCHECK(client); |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 637 | // Check if the URL can be sent in any suggest request. |
| 638 | const TemplateURLService* template_url_service = |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 639 | client->GetTemplateURLService(); |
Kevin Bailey | 9bdd15d | 2018-02-28 04:07:49 | [diff] [blame] | 640 | DCHECK(template_url_service); |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 641 | const TemplateURL* default_provider = |
| 642 | template_url_service->GetDefaultSearchProvider(); |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 643 | |
| 644 | GURL current_url = input.current_url(); |
| 645 | metrics::OmniboxEventProto::PageClassification current_page_classification = |
| 646 | input.current_page_classification(); |
| 647 | |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 648 | const bool can_send_current_url = CanSendURL( |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 649 | current_url, suggest_url, default_provider, current_page_classification, |
| 650 | template_url_service->search_terms_data(), client, false); |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 651 | // Collect metrics on eligibility. |
| 652 | GURL arbitrary_insecure_url(kArbitraryInsecureUrlString); |
| 653 | ZeroSuggestEligibility eligibility = ZeroSuggestEligibility::ELIGIBLE; |
| 654 | if (!can_send_current_url) { |
| 655 | const bool can_send_ordinary_url = |
| 656 | CanSendURL(arbitrary_insecure_url, suggest_url, default_provider, |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 657 | current_page_classification, |
| 658 | template_url_service->search_terms_data(), client, false); |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 659 | eligibility = can_send_ordinary_url |
| 660 | ? ZeroSuggestEligibility::URL_INELIGIBLE |
| 661 | : ZeroSuggestEligibility::GENERALLY_INELIGIBLE; |
| 662 | } |
| 663 | UMA_HISTOGRAM_ENUMERATION( |
Tomasz Wiszkowski | 57492ab | 2019-05-29 21:28:27 | [diff] [blame] | 664 | kOmniboxZeroSuggestEligibleHistogramName, static_cast<int>(eligibility), |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 665 | static_cast<int>(ZeroSuggestEligibility::ELIGIBLE_MAX_VALUE)); |
| 666 | |
Moe Ahmadi | 0993aec | 2019-09-19 21:42:30 | [diff] [blame] | 667 | const auto field_trial_variants = |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 668 | OmniboxFieldTrial::GetZeroSuggestVariants(current_page_classification); |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 669 | |
Stepan Khapugin | 5187a46 | 2020-01-07 13:16:26 | [diff] [blame] | 670 | if (base::Contains(field_trial_variants, kNoneVariant)) |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 671 | return NONE; |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 672 | |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 673 | if (current_page_classification == OmniboxEventProto::CHROMEOS_APP_LIST) |
Tommy C. Li | d77691a | 2019-06-05 02:07:46 | [diff] [blame] | 674 | return REMOTE_NO_URL; |
Jenny Zhang | 5bc2e3d | 2018-09-10 18:50:55 | [diff] [blame] | 675 | |
Tommy Li | e0a3a99 | 2020-05-29 21:32:05 | [diff] [blame] | 676 | // Contextual Open Web - (same client side behavior for multiple variants). |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 677 | if (current_page_classification == OmniboxEventProto::OTHER && |
Tommy Li | 31e27a63 | 2020-08-20 03:06:51 | [diff] [blame] | 678 | can_send_current_url) { |
| 679 | if (input.focus_type() == OmniboxFocusType::ON_FOCUS && |
| 680 | (base::FeatureList::IsEnabled( |
| 681 | omnibox::kOnFocusSuggestionsContextualWeb) || |
| 682 | base::FeatureList::IsEnabled( |
| 683 | omnibox::kOnFocusSuggestionsContextualWebOnContent))) { |
| 684 | return REMOTE_SEND_URL; |
| 685 | } |
| 686 | |
| 687 | if (input.focus_type() == OmniboxFocusType::DELETED_PERMANENT_TEXT && |
| 688 | base::FeatureList::IsEnabled( |
| 689 | omnibox::kClobberTriggersContextualWebZeroSuggest)) { |
| 690 | return REMOTE_SEND_URL; |
| 691 | } |
Tommy Li | 5578402 | 2020-04-28 20:58:18 | [diff] [blame] | 692 | } |
| 693 | |
Moe Ahmadi | 31147bc | 2020-06-02 19:07:56 | [diff] [blame] | 694 | // Reactive Zero-Prefix Suggestions (rZPS) on NTP cases. |
Moe Ahmadi | 189b653 | 2020-09-02 17:57:12 | [diff] [blame] | 695 | bool check_authentication_state = !base::FeatureList::IsEnabled( |
| 696 | omnibox::kOmniboxTrendingZeroPrefixSuggestionsOnNTP); |
| 697 | bool remote_no_url_allowed = RemoteNoUrlSuggestionsAreAllowed( |
| 698 | client, template_url_service, check_authentication_state); |
Tommy Li | b4b3bb5b | 2020-05-01 02:34:56 | [diff] [blame] | 699 | if (remote_no_url_allowed) { |
| 700 | // NTP Omnibox. |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 701 | if ((current_page_classification == OmniboxEventProto::NTP || |
| 702 | current_page_classification == |
Tommy Li | b4b3bb5b | 2020-05-01 02:34:56 | [diff] [blame] | 703 | OmniboxEventProto::INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS) && |
| 704 | base::FeatureList::IsEnabled( |
Moe Ahmadi | 31147bc | 2020-06-02 19:07:56 | [diff] [blame] | 705 | omnibox::kReactiveZeroSuggestionsOnNTPOmnibox)) { |
Tommy Li | b4b3bb5b | 2020-05-01 02:34:56 | [diff] [blame] | 706 | return REMOTE_NO_URL; |
| 707 | } |
| 708 | // NTP Realbox. |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 709 | if (current_page_classification == OmniboxEventProto::NTP_REALBOX && |
Tommy Li | b4b3bb5b | 2020-05-01 02:34:56 | [diff] [blame] | 710 | base::FeatureList::IsEnabled( |
Moe Ahmadi | 31147bc | 2020-06-02 19:07:56 | [diff] [blame] | 711 | omnibox::kReactiveZeroSuggestionsOnNTPRealbox)) { |
Tommy Li | b4b3bb5b | 2020-05-01 02:34:56 | [diff] [blame] | 712 | return REMOTE_NO_URL; |
| 713 | } |
| 714 | } |
| 715 | |
Tommy Li | 0801a8b | 2020-05-30 00:28:55 | [diff] [blame] | 716 | if (base::Contains(field_trial_variants, kRemoteNoUrlVariant) && |
| 717 | remote_no_url_allowed) { |
| 718 | return REMOTE_NO_URL; |
Tommy C. Li | 393c1b14 | 2019-05-22 00:28:41 | [diff] [blame] | 719 | } |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 720 | |
Moe Ahmadi | 0993aec | 2019-09-19 21:42:30 | [diff] [blame] | 721 | if (base::Contains(field_trial_variants, kRemoteSendUrlVariant) && |
| 722 | can_send_current_url) |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 723 | return REMOTE_SEND_URL; |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 724 | |
Moe Ahmadi | 0993aec | 2019-09-19 21:42:30 | [diff] [blame] | 725 | if (base::Contains(field_trial_variants, kMostVisitedVariant)) |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 726 | return MOST_VISITED; |
| 727 | |
Moe Ahmadi | 8ef94b7 | 2020-08-13 23:18:15 | [diff] [blame] | 728 | #if !defined(OS_IOS) |
| 729 | // For Desktop and Android, default to REMOTE_NO_URL on the NTP, if allowed. |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 730 | if (IsNTPPage(current_page_classification) && remote_no_url_allowed) |
Tommy Li | 0801a8b | 2020-05-30 00:28:55 | [diff] [blame] | 731 | return REMOTE_NO_URL; |
| 732 | #endif |
| 733 | |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 734 | #if defined(OS_ANDROID) || defined(OS_IOS) |
Moe Ahmadi | 8ef94b7 | 2020-08-13 23:18:15 | [diff] [blame] | 735 | // For Android and iOS, default to MOST_VISITED everywhere except on the SERP. |
Tommy Li | 26a9f58 | 2020-08-18 23:59:55 | [diff] [blame] | 736 | if (!IsSearchResultsPage(current_page_classification)) { |
Kevin Bailey | 5fea432 | 2018-03-21 22:36:05 | [diff] [blame] | 737 | return MOST_VISITED; |
Tommy C. Li | 393c1b14 | 2019-05-22 00:28:41 | [diff] [blame] | 738 | } |
Tommy C. Li | 0af0956 | 2019-06-11 23:58:51 | [diff] [blame] | 739 | #endif |
Tommy C. Li | c79d39ab | 2019-06-04 16:58:56 | [diff] [blame] | 740 | |
| 741 | return NONE; |
Gheorghe Comanici | 9a364f57 | 2018-01-24 17:22:00 | [diff] [blame] | 742 | } |