Avi Drissman | 8ba1bad | 2022-09-13 19:22:36 | [diff] [blame] | 1 | // Copyright 2017 The Chromium Authors |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "components/metrics/field_trials_provider.h" |
| 6 | |
Arthur Sonzogni | b7c1fd51 | 2024-12-10 09:58:59 | [diff] [blame] | 7 | #include <array> |
Helmut Januschka | ff1c3ec | 2024-04-25 19:38:32 | [diff] [blame] | 8 | #include <string_view> |
| 9 | |
Arthur Sonzogni | 3250cb1 | 2024-12-10 16:04:03 | [diff] [blame] | 10 | #include "base/containers/span.h" |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 11 | #include "base/metrics/field_trial.h" |
Takashi Sakamoto | ba225e7 | 2023-03-16 14:09:09 | [diff] [blame] | 12 | #include "base/test/scoped_feature_list.h" |
Kevin McNee | 5e754b1 | 2021-08-18 21:59:30 | [diff] [blame] | 13 | #include "base/threading/platform_thread.h" |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 14 | #include "components/variations/active_field_trials.h" |
| 15 | #include "components/variations/synthetic_trial_registry.h" |
Luc Nguyen | 69147e0 | 2022-01-24 20:32:10 | [diff] [blame] | 16 | #include "components/variations/synthetic_trials.h" |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 17 | #include "testing/gtest/include/gtest/gtest.h" |
Steven Holte | f9d5ed6 | 2017-10-21 02:02:30 | [diff] [blame] | 18 | #include "third_party/metrics_proto/system_profile.pb.h" |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 19 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 20 | using ActiveGroup = base::FieldTrial::ActiveGroup; |
| 21 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 22 | namespace variations { |
| 23 | |
| 24 | namespace { |
| 25 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 26 | constexpr const char* kSuffix = "UKM"; |
| 27 | |
Arthur Sonzogni | b7c1fd51 | 2024-12-10 09:58:59 | [diff] [blame] | 28 | const auto kFieldTrials = std::to_array<ActiveGroup>({ |
| 29 | {"Trial1", "Group1"}, |
| 30 | {"Trial2", "Group2"}, |
| 31 | {"Trial3", "Group3"}, |
| 32 | }); |
Arthur Sonzogni | 3250cb1 | 2024-12-10 16:04:03 | [diff] [blame] | 33 | const auto kSyntheticFieldTrials = std::to_array<ActiveGroup>({ |
| 34 | {"Synthetic1", "SyntheticGroup1"}, |
| 35 | {"Synthetic2", "SyntheticGroup2"}, |
| 36 | }); |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 37 | |
| 38 | ActiveGroupId ToActiveGroupId(ActiveGroup active_group, |
| 39 | std::string suffix = ""); |
| 40 | |
Arthur Sonzogni | 3250cb1 | 2024-12-10 16:04:03 | [diff] [blame] | 41 | const auto kFieldTrialIds = std::to_array<ActiveGroupId>({ |
| 42 | ToActiveGroupId(kFieldTrials[0]), |
| 43 | ToActiveGroupId(kFieldTrials[1]), |
| 44 | ToActiveGroupId(kFieldTrials[2]), |
| 45 | }); |
| 46 | const auto kAllTrialIds = std::to_array<ActiveGroupId>({ |
| 47 | ToActiveGroupId(kFieldTrials[0]), |
| 48 | ToActiveGroupId(kFieldTrials[1]), |
| 49 | ToActiveGroupId(kFieldTrials[2]), |
| 50 | ToActiveGroupId(kSyntheticFieldTrials[0]), |
| 51 | ToActiveGroupId(kSyntheticFieldTrials[1]), |
| 52 | }); |
| 53 | const auto kAllTrialIdsWithSuffixes = std::to_array<ActiveGroupId>({ |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 54 | ToActiveGroupId(kFieldTrials[0], kSuffix), |
| 55 | ToActiveGroupId(kFieldTrials[1], kSuffix), |
| 56 | ToActiveGroupId(kFieldTrials[2], kSuffix), |
| 57 | ToActiveGroupId(kSyntheticFieldTrials[0], kSuffix), |
Arthur Sonzogni | 3250cb1 | 2024-12-10 16:04:03 | [diff] [blame] | 58 | ToActiveGroupId(kSyntheticFieldTrials[1], kSuffix), |
| 59 | }); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 60 | |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 61 | // Check that the field trials in |system_profile| correspond to |expected|. |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 62 | void CheckFieldTrialsInSystemProfile( |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 63 | const metrics::SystemProfileProto& system_profile, |
Arthur Sonzogni | 3250cb1 | 2024-12-10 16:04:03 | [diff] [blame] | 64 | base::span<const ActiveGroupId> expected) { |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 65 | for (int i = 0; i < system_profile.field_trial_size(); ++i) { |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 66 | const metrics::SystemProfileProto::FieldTrial& field_trial = |
| 67 | system_profile.field_trial(i); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 68 | EXPECT_EQ(expected[i].name, field_trial.name_id()); |
| 69 | EXPECT_EQ(expected[i].group, field_trial.group_id()); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 70 | } |
| 71 | } |
| 72 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 73 | ActiveGroupId ToActiveGroupId(ActiveGroup active_group, std::string suffix) { |
| 74 | return MakeActiveGroupId(active_group.trial_name + suffix, |
| 75 | active_group.group_name + suffix); |
| 76 | } |
| 77 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 78 | } // namespace |
| 79 | |
| 80 | class FieldTrialsProviderTest : public ::testing::Test { |
| 81 | public: |
Takashi Sakamoto | ba225e7 | 2023-03-16 14:09:09 | [diff] [blame] | 82 | FieldTrialsProviderTest() { scope_.InitWithEmptyFeatureAndFieldTrialLists(); } |
| 83 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 84 | ~FieldTrialsProviderTest() override = default; |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 85 | |
| 86 | protected: |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 87 | void SetUp() override { |
| 88 | // Register the field trials. |
| 89 | for (const ActiveGroup& trial : kFieldTrials) { |
| 90 | base::FieldTrial* field_trial = base::FieldTrialList::CreateFieldTrial( |
| 91 | trial.trial_name, trial.group_name); |
Steven Holte | f155160 | 2022-09-03 06:38:38 | [diff] [blame] | 92 | // Call Activate() to finalize and mark the field trial as active. |
| 93 | field_trial->Activate(); |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 94 | } |
| 95 | } |
| 96 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 97 | // Register trials which should get recorded. |
| 98 | void RegisterExpectedSyntheticTrials() { |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 99 | for (const ActiveGroup& trial : kSyntheticFieldTrials) { |
| 100 | registry_.RegisterSyntheticFieldTrial(SyntheticTrialGroup( |
| 101 | trial.trial_name, trial.group_name, |
| 102 | /*annotation_mode=*/ |
| 103 | variations::SyntheticTrialAnnotationMode::kNextLog)); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 104 | } |
| 105 | } |
| 106 | // Register trial which shouldn't get recorded. |
| 107 | void RegisterExtraSyntheticTrial() { |
Luc Nguyen | 69147e0 | 2022-01-24 20:32:10 | [diff] [blame] | 108 | registry_.RegisterSyntheticFieldTrial(SyntheticTrialGroup( |
Luc Nguyen | 75a8bb2ee | 2022-05-04 20:53:55 | [diff] [blame] | 109 | "ExtraSynthetic", "ExtraGroup", |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 110 | /*annotation_mode=*/ |
Luc Nguyen | 75a8bb2ee | 2022-05-04 20:53:55 | [diff] [blame] | 111 | variations::SyntheticTrialAnnotationMode::kNextLog)); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 112 | } |
| 113 | |
| 114 | // Waits until base::TimeTicks::Now() no longer equals |value|. This should |
| 115 | // take between 1-15ms per the documented resolution of base::TimeTicks. |
| 116 | void WaitUntilTimeChanges(const base::TimeTicks& value) { |
| 117 | while (base::TimeTicks::Now() == value) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 118 | base::PlatformThread::Sleep(base::Milliseconds(1)); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 119 | } |
| 120 | } |
| 121 | |
| 122 | SyntheticTrialRegistry registry_; |
Takashi Sakamoto | ba225e7 | 2023-03-16 14:09:09 | [diff] [blame] | 123 | base::test::ScopedFeatureList scope_; |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 124 | }; |
| 125 | |
| 126 | TEST_F(FieldTrialsProviderTest, ProvideSyntheticTrials) { |
Helmut Januschka | ff1c3ec | 2024-04-25 19:38:32 | [diff] [blame] | 127 | FieldTrialsProvider provider(®istry_, std::string_view()); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 128 | |
| 129 | RegisterExpectedSyntheticTrials(); |
| 130 | // Make sure these trials are older than the log. |
| 131 | WaitUntilTimeChanges(base::TimeTicks::Now()); |
| 132 | |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 133 | // Get the current time and wait for it to change. |
| 134 | base::TimeTicks log_creation_time = base::TimeTicks::Now(); |
| 135 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 136 | // Make sure that the log is older than the trials that should be excluded. |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 137 | WaitUntilTimeChanges(log_creation_time); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 138 | |
| 139 | RegisterExtraSyntheticTrial(); |
| 140 | |
| 141 | metrics::SystemProfileProto proto; |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 142 | provider.ProvideSystemProfileMetricsWithLogCreationTime(log_creation_time, |
| 143 | &proto); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 144 | |
Daniel Cheng | 7b7aaecc | 2022-02-26 17:57:25 | [diff] [blame] | 145 | EXPECT_EQ(std::size(kAllTrialIds), |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 146 | static_cast<size_t>(proto.field_trial_size())); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 147 | CheckFieldTrialsInSystemProfile(proto, kAllTrialIds); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 148 | } |
| 149 | |
| 150 | TEST_F(FieldTrialsProviderTest, NoSyntheticTrials) { |
Helmut Januschka | ff1c3ec | 2024-04-25 19:38:32 | [diff] [blame] | 151 | FieldTrialsProvider provider(nullptr, std::string_view()); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 152 | |
| 153 | metrics::SystemProfileProto proto; |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 154 | provider.ProvideSystemProfileMetricsWithLogCreationTime(base::TimeTicks(), |
| 155 | &proto); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 156 | |
Daniel Cheng | 7b7aaecc | 2022-02-26 17:57:25 | [diff] [blame] | 157 | EXPECT_EQ(std::size(kFieldTrialIds), |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 158 | static_cast<size_t>(proto.field_trial_size())); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 159 | CheckFieldTrialsInSystemProfile(proto, kFieldTrialIds); |
| 160 | } |
| 161 | |
| 162 | TEST_F(FieldTrialsProviderTest, ProvideCurrentSessionData) { |
| 163 | metrics::ChromeUserMetricsExtension uma_log; |
| 164 | uma_log.system_profile(); |
| 165 | |
| 166 | // {1, 1} should not be in the resulting proto as ProvideCurrentSessionData() |
| 167 | // clears existing trials and sets the trials to be those determined by |
| 168 | // GetSyntheticFieldTrialsOlderThan() and GetFieldTrialIds(). |
| 169 | metrics::SystemProfileProto::FieldTrial* trial = |
| 170 | uma_log.mutable_system_profile()->add_field_trial(); |
| 171 | trial->set_name_id(1); |
| 172 | trial->set_group_id(1); |
| 173 | |
Helmut Januschka | ff1c3ec | 2024-04-25 19:38:32 | [diff] [blame] | 174 | FieldTrialsProvider provider(®istry_, std::string_view()); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 175 | RegisterExpectedSyntheticTrials(); |
| 176 | WaitUntilTimeChanges(base::TimeTicks::Now()); |
| 177 | provider.SetLogCreationTimeForTesting(base::TimeTicks::Now()); |
| 178 | |
| 179 | provider.ProvideCurrentSessionData(&uma_log); |
| 180 | |
Daniel Cheng | 7b7aaecc | 2022-02-26 17:57:25 | [diff] [blame] | 181 | EXPECT_EQ(std::size(kAllTrialIds), |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 182 | static_cast<size_t>(uma_log.system_profile().field_trial_size())); |
| 183 | CheckFieldTrialsInSystemProfile(uma_log.system_profile(), kAllTrialIds); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 184 | } |
| 185 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 186 | TEST_F(FieldTrialsProviderTest, GetAndWriteFieldTrialsWithSuffixes) { |
| 187 | metrics::ChromeUserMetricsExtension uma_log; |
| 188 | uma_log.system_profile(); |
| 189 | |
| 190 | FieldTrialsProvider provider(®istry_, kSuffix); |
| 191 | RegisterExpectedSyntheticTrials(); |
| 192 | WaitUntilTimeChanges(base::TimeTicks::Now()); |
| 193 | provider.SetLogCreationTimeForTesting(base::TimeTicks::Now()); |
| 194 | |
| 195 | provider.ProvideCurrentSessionData(&uma_log); |
| 196 | |
| 197 | EXPECT_EQ(std::size(kAllTrialIdsWithSuffixes), |
| 198 | static_cast<size_t>(uma_log.system_profile().field_trial_size())); |
| 199 | CheckFieldTrialsInSystemProfile(uma_log.system_profile(), |
| 200 | kAllTrialIdsWithSuffixes); |
| 201 | } |
| 202 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 203 | } // namespace variations |