aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/console
diff options
context:
space:
mode:
authorJarek Kobus <[email protected]>2020-11-16 21:58:53 +0100
committerJarek Kobus <[email protected]>2020-11-16 22:11:46 +0000
commiteaba657d90c896e45fbd2ab24276b7cc86ec5653 (patch)
tree9d195e2ae8744bbabdc6f2171feec132ba20dc69 /src/plugins/debugger/console
parent27c962f50301a95823f4bfe13657419779d4cb93 (diff)
Fix warnings about possible detach of temporary objects
Calling first() or last() on temporary container may unnecessarily detach the container. Fix it by calling constFirst() and constLast(). Change-Id: I2460efd5dbee1534eec8a514d9bff2a947bfddf9 Reviewed-by: Tim Jenssen <[email protected]>
Diffstat (limited to 'src/plugins/debugger/console')
-rw-r--r--src/plugins/debugger/console/consoleview.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/debugger/console/consoleview.cpp b/src/plugins/debugger/console/consoleview.cpp
index ad54b2d4b12..5d3fa6f6912 100644
--- a/src/plugins/debugger/console/consoleview.cpp
+++ b/src/plugins/debugger/console/consoleview.cpp
@@ -184,7 +184,7 @@ void ConsoleView::onRowActivated(const QModelIndex &index)
return;
const QFileInfo fi = m_finder.findFile(model()->data(index, ConsoleItem::FileRole).toString())
- .first().toFileInfo();
+ .constFirst().toFileInfo();
if (fi.exists() && fi.isFile() && fi.isReadable()) {
Core::EditorManager::openEditorAt(fi.canonicalFilePath(),
model()->data(index, ConsoleItem::LineRole).toInt());