| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Change-Id: I4b2b47f6fa450c5f61be85418f918774b914ed1f
|
| |\
| | |
| | |
| | | |
Change-Id: Ifdf78ab530f326080d447e0d853620188272b511
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This worked somewhat accidentally until
72ddf3320bf585760d6aa887a04bcbaa25cd8beb.
Now we do it properly.
Change-Id: I0f7a68e8d7c58e4d19a3ce81b343d54a06e26840
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
... and not for Qt4.
Fixes: QTCREATORBUG-33462
Change-Id: I8980c410504c5829e391036d842e05ee7d229cba
Reviewed-by: Alexandru Croitor <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
... in order to have valid presets.
The CMake documentation states:
> CMakePresets.json and CMakeUserPresets.json live in the project's root
directory. They both have exactly the same format, and both are optional
(though at least one must be present if --preset is specified)
Amends 284d59f5268d9424690aea42bc9ab753bd16dc65
Fixes: QTCREATORBUG-33509
Change-Id: Ie1f5048cf09fccb6db2d9d760088f8de65c8ec67
Reviewed-by: Marcus Tillmanns <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The QTabBar handles dragging tabs between different positions within the
same tab bar, but there is no built-in way for dragging between tab
bars.
Monitor the mouse move events when the left button is pressed, and if it
moves out of the parent editor view:
- make QTabBar stop the dragging (that is a hack, there is no official
way to do it) and move the tab back to its original position
- start our own drag, like we do when dragging the document icon from
the tool bar
Change-Id: Id0c22c80c3fab698968d60ccf928e6dac6300b17
Reviewed-by: David Schulz <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends 303c1934241b3. Closer to a proper solution.
Change-Id: I661b5d2046b5facb6217e731c8a15b352fe7c9fe
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: I68a14a1e322eb3387b6953ebab5ae5a6935a9d32
Reviewed-by: hjk <[email protected]>
Reviewed-by: Alessandro Portale <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
...for each kit that users activate for a project when
creating or opening it.
Task-number: QTCREATORBUG-33078
Change-Id: I798dc5af04df4df388b3fd2fad9806d692b555b0
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I5c3a1ed06903957ce60d2b56638876db98d2a976
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I022c09464f409dac7b2e34bb9a582c752e834ea8
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ia0dfb06493351bfc8a347527b7ccdc45559c082e
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ic957be2a95aa67ebec65e2eb96e294e108cb4cc1
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
So we don't accidentally create additional strong IDevice::ConstPtr
copies.
Change-Id: I46debbd51ff10373b3bdb17dec2e792fa16d5f3f
Reviewed-by: Marcus Tillmanns <[email protected]>
Reviewed-by: Christian Kandeler <[email protected]>
Reviewed-by: Jarek Kobus <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
According to ASAN there are still issues with the device destruction
order. This here works around by extending the lifetime of the
container.
Change-Id: I5cdfe0f596217fe58f91089858e24bc0ad836508
Reviewed-by: Jarek Kobus <[email protected]>
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some of the functions called in the project root didn't check if SBOM
generation is enabled, and tried to unconditionally call Qt SBOM
functions.
This led to an error like:
CMake Error at qtcreator/cmake/QtCreatorSbom.cmake:449
(_qt_internal_sbom_get_spdx_license_expression):
Unknown CMake command
"_qt_internal_sbom_get_spdx_license_expression".
Call Stack (most recent call first):
licensechecker/CMakeLists.txt:22
(qtc_sbom_get_default_commercial_license)
Guard them with a check for QT_GENERATE_SBOM.
Change-Id: I91241b917165f38f8215fbca19d00d55c594fa75
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise Qt issues warnings about disconnecting from
destroyed signal.
Change-Id: If729c39b523d7b147ba65edae43439749d21a019
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTCREATORBUG-33078
Change-Id: If71191a570605d0ad5427cbefbdaed402070d392
Reviewed-by: Christian Kandeler <[email protected]>
Reviewed-by: Leena Miettinen <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Check that we do not open a file that doesn't exist as the main file,
but print a warning to console, so maybe someone can notice and fixe Qt.
Fixes: QTCREATORBUG-33519
Change-Id: I380e14e4c7b0bb80024e617f480fab3074d25924
Reviewed-by: Alessandro Portale <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ieedd5e8042f9575f995585f12f136270404b9c9b
Reviewed-by: David Schulz <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTCREATORBUG-33078
Change-Id: I406caa821e010cac6ce71c9ca822f24aae099337
Reviewed-by: André Hartmann <[email protected]>
Reviewed-by: Teea Põldsam <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends e78975cfde18567692eba28202b977a392d37bac
that tried to fix a crash when disabling a kit while CMake configuration
is still running.
But the new connection guard fails to disconnect when the
CMakeBuildSettingsWidget itself dies, leading to even worse crashes.
The crash when disabling a kit happens because the parsingFinished
notification comes while the Target, BuildConfiguration, and
CMakeBuildSystem are already destructing.
Revert to the right connection guard, but let the code there be no-op if
we are already deconstructing everything.
Fixes: QTCREATORBUG-33517
Change-Id: I5f71d212a96f428513e4f5c77b42c0efd9dfe355
Reviewed-by: hjk <[email protected]>
Reviewed-by: Cristian Adam <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Mention that build configuration is added automatically
using the default kit
- Describe cargo-build support for Rust
Task-number: QTCREATORBUG-33078
Change-Id: I9f795213acddf3f3349bd21d1b5f4bcfa4375986
Reviewed-by: Teea Põldsam <[email protected]>
Reviewed-by: David Schulz <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise Qt issues a warning:
QObject::disconnect: wildcard call disconnects from destroyed
signal of ProjectExplorer::TargetSetupPage::TargetSetupPage.
Change-Id: Ica9f1d9d3ce9f6cdaa5b7946c855efecf411ba26
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I6e0327d7bea075eb6edaca7b4795b201646532ed
Reviewed-by: Leena Miettinen <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is another fallout of the change in Qt that QTemporaryDir is no
longer a canonical file path on macOS, but /var/... (while the canonical
path is /private/var). But we need the assumption that the original file
paths for these tests are _not_ involving symlinks.
Amends 968135b74b660ac5849329c68276ded691c2f501
Change-Id: I0ee3e44b2db52182cce65d65cfebbf71b450886e
Reviewed-by: Marcus Tillmanns <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The example manifests specify a list of files to open, and can specify a
"main file" that should be the one that is made active in case of
multiple files.
Since 018d49f417eb ICore::openFiles only actually opens the first file
it is given. The rest is opened as suspended documents. Adapt the code
accordingly.
Fixes: QTCREATORBUG-33266
Change-Id: I2db0fd73b7fc7eaffaa23b473bfd7031411fa09a
Reviewed-by: David Schulz <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Let the QtVersionManager do the example parsing with its regular means
instead. As a side effect this avoids that the Overview page tries to
access remote Qt versions and tries Qt versions in the same order as the
examples page. It also unifies parsing and opening of examples for the
future.
Since the overview page is already parsing for examples to decide if an
example should appear at all, we can also use that to avoid duplicating
the descriptions for examples.
Change-Id: I0599af637ca9718c54a8e2b729881d72da15fe21
Reviewed-by: Alessandro Portale <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Replaces the monolithic ProjectExplorerPlugin::renameFiles() with a
three-stage implementation:
1. file-system rename
2. project update
3. diagnostics
Fixes crashes on nullptr nodes and subtree invalidation during QML
project reparses.
Change-Id: Ibe46db6e0f4498df7846e7cde2fd9a48394eed40
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is allowed in addition to "class" from C++17 on.
Change-Id: Ib77ea503ecbcad187727d38c3f222ab5c043ea6b
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends 968135b74b660ac5849329c68276ded691c2f501
Change-Id: I7142799d71fb5602499ff8f9d384ab18888a00d5
Reviewed-by: Marcus Tillmanns <[email protected]>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I9d7ddb6ab123cbd48cc6638b8a3f76985a988d0f
Reviewed-by: Eike Ziller <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends 69d295b9f3fe6bf2.
Change-Id: I0639946b7e7e3ed6b9d37cfbebfffad6dedeb71f
Reviewed-by: Eike Ziller <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since the last rewrite we were reading session file contents
unconditionally for all sessions, running in some cases into
sessions that take 45ms to read their EditorData. With several
of such sessions this becomes user visible, in my case >300ms.
Fix this by only reading session data of sessions that are
expanded in the session list.
The is overall still a bit slower (~65ms) for me then it was
in QtC 16 (~30ms) but not noticeably so.
Change-Id: Id12af4157553eb5e5fb1c6a637276c910ba799e3
Reviewed-by: Alessandro Portale <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends ebf4e052f9329393c486c5623baf0ce0039609ce.
Fixes: QTCREATORBUG-33261
Change-Id: I7d2016181f0dc2e9a3fcebccd87a8d3bb8344ff2
Reviewed-by: David Schulz <[email protected]>
|
| |\ \ |
|
| | |\|
| | | |
| | | |
| | | | |
Change-Id: I20a2e6046e3425273a14fcb4c50760fd8dfae559
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As a workaround for the Style issues on the latest macos 26
Change-Id: Icf663c2f836fe34ff608679520843f8671e5fdd4
Reviewed-by: Eike Ziller <[email protected]>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
There is no "not" operator in JavaScript and it may not be part of the
string itself anyway.
Fixes: QTCREATORBUG-33502
Change-Id: I9b49b4be4ae0e216fedecef81c41251e9756dd23
Reviewed-by: Christian Stenger <[email protected]>
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I1949241a5fa5d39bd22639d5bae898add30c03e3
Reviewed-by: Christian Stenger <[email protected]>
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
Fixes: QTCREATORBUG-33500
Change-Id: Iea93928e7d82bce55f2f03437bfa60fccf4cc825
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In the situation
/a/file3.txt
/x/linktest1.txt -> ../a/file3.txt
/a/dirlink -> ../x
unfortunately symLinkTarget("/a/dirlink/linktest1.txt")
returns "/a/a/file3.txt", because readlink of that file returns
"../a/file3.txt" and that relative path is then resolved via the original
path, "/a/dirlink/../a/file3.txt".
It does not recognize that a directory link is involved that changes the
depth of the hierarchy.
That also breaks FilePath::resolveSymLinks that relies on symLinkTarget.
Fix it by checking the whole parent hierarchy of the path for symlinks
instead of just the file itself. If a link is found, that counts towards
the max 16 jumps that it does.
Adds some tests for resolveSymLinks.
Fixes: QTCREATORBUG-33335
Change-Id: Id55ae44cc4e8fabaf6ae37e87b0bc7d07e032d21
Reviewed-by: Marcus Tillmanns <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTCREATORBUG-33078
Change-Id: I132910e2b85d967370eb96b59af8da0fc19c0e1d
Reviewed-by: Teea Põldsam <[email protected]>
Reviewed-by: Christian Stenger <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: I0895c523c6549fcf59af3a2a680e0a0ce31cff13
Reviewed-by: Eike Ziller <[email protected]>
Reviewed-by: David Schulz <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends 7f1e16172a6a8a0a66c8505df80fcf156a26f894
As the CMake documentation states:
> If multiple inherits presets provide conflicting values for the same
field, the earlier preset in the inherits array will be preferred.
By traversing the list of presets in order, we achieve exactly this.
This change set adds a test for this bug, and one for the amended
commmit.
Fixes: QTCREATORBUG-32853
Change-Id: I4e1b2a0ce8cc5386efd8103095ce1b07d0330a40
Reviewed-by: Cristian Adam <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
At a glance, the obvious candidate for the crash reported in the bug
report was the `m_buildConfig` QPointer variable.
This ensures guarding against null access.
Fixes: QTCREATORBUG-33494
Change-Id: I068b4a10f82c9afc9c4789092c86fb2930dd66e2
Reviewed-by: hjk <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Describe the Mount Command Bridge option
- Update a screenshot
- Add a new image to topics
- Add missing options to a table
Task-number: QTCREATORBUG-33078
Change-Id: Ib0ef1cb7fc829eb040d3e2388c6408b5c19a7260
Reviewed-by: Leena Miettinen <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Describe the default behavior (open files are
analyzed automatically).
Task-number: QTCREATORBUG-33078
Change-Id: Idb46b267306d5ccb7f53242303a016337563a384
Reviewed-by: Christian Kandeler <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The aspect calls can have side effects and are therefore not pure read
accesses.
Change-Id: Ib72019e15c1da0baef7e222759c6a141467512c4
Reviewed-by: hjk <[email protected]>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is triggered by the base BuildConfiguration destructor, when
the additional aspects in the derived class are already gone.
Change-Id: I362013d1543e0d1b8ac64cf43ffba5d2f7752146
Reviewed-by: Christian Kandeler <[email protected]>
Reviewed-by: Cristian Adam <[email protected]>
|