aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/mercurial
Commit message (Collapse)AuthorAgeFilesLines
* Replace a few FileSaver::errorString() uses with Result<>::error()hjk2025-04-231-2/+2
| | | | | Change-Id: Iad11dcc7393386d3ecc243afd7b51cc93eeab426 Reviewed-by: Jarek Kobus <[email protected]>
* Git: Add gitignore on repo creation in existing projectAndre Hartmann2025-03-081-1/+1
| | | | | | | | | | | | | | | | When a git repository is created by the project wizard, the .gitignore is created from a QtCreator template and added to the "files to be committed" list. Now perform the same when creating the repository later in an already existing project directory. If the project already contains a .gitignore, then use this existing file and just mark it for committing to git. Fixes: QTCREATORBUG-29776 Change-Id: Ie153c8dfb09a5640cf79941dfe7cfb608648a4b9 Reviewed-by: Orgad Shaneh <[email protected]>
* VcsBase: Remove some dead endsJarek Kobus2025-02-102-46/+0
| | | | | | | | Detected by Axivion plugin. Change-Id: Id4ee08a0e0607d8ac243113f783f8d56876f9617 Reviewed-by: André Hartmann <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* Mercurial: Remove dead endsJarek Kobus2025-02-109-55/+1
| | | | | | | | Detected by Axivion plugin. Change-Id: I9e39b345c1fe568d574aa0615c67b68c63359725 Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: André Hartmann <[email protected]>
* Utils: Rename FilePath::toString() into toUrlishString()hjk2025-01-104-15/+15
| | | | | | | | | | | | | | | | toString() is almost always the wrong conversion, but unfortunately too easy to find and often even working at least for local setup. This here raises the bar as the non-availability of the "obvious" toString() hopefully helps people to think about the semantics of the needed conversion and choose the right toXXX() function. The chosen new name is intentional ugly to reduce the likelihood that this (still almost always wrong) function is used out of convenience. Change-Id: I57f1618dd95ef2629d7d978688d130275e096c0f Reviewed-by: Eike Ziller <[email protected]>
* VCS: Detect VCS directories even for disabled VCS pluginsEike Ziller2024-12-101-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Most of the version control support plugins detect that a directory/file is under version control by looking for certain files in the directory structure. This search doesn't really need anything specific from the plugin, except for a list of file names. Allow version control plugins to specify the list of files to look for in their plugin meta data as "VcsDetectionFiles". When it is checked if a directory is under version control, and none is found from the enabled plugins, use the meta data to find out if any installed but disabled plugin feels responsible for that directory. Show a notification if a plugin is found that handles such a detected version control system, with the option to enable the plugin and restart QtC if necessary. Since this adds discoverability of the version control support even when plugins are disabled, disable the VCS plugins that can use this mechanism (except for Git). Change-Id: Ib507572c0065dd889a2f9b780c794f9cd985e265 Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: Marcus Tillmanns <[email protected]>
* VCS: Move convenience function to Core::VcsManagerEike Ziller2024-11-291-2/+2
| | | | | | | | | It doesn't have any dependencies to VcsBase, and this way we can utilize it in VcsManager directly. Change-Id: I62c6314b363904055127bc11c4f7426948805c3d Reviewed-by: André Hartmann <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* VCS: Consolidate managesDirectory()Eike Ziller2024-11-291-2/+2
| | | | | | | | | | Most version control implementations use one or one of a set of specific files to find a toplevel directory for that version control. Share the code that searches for these. Change-Id: Ia308262018f79e59de33b862a020b8cb8138f17f Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: André Hartmann <[email protected]>
* VCS: Remove an unnecessary indirectionEike Ziller2024-11-293-8/+2
| | | | | | | | | | Remove VcsBaseClient::findTopLevelForFile. It was only used by a few IVersionControl subclasses and always only redirected to VcsBase::findRepositoryForFile in these cases. Change-Id: I7af0d98b3289566ca82384e51b357654f4990d56 Reviewed-by: André Hartmann <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* Plugins M-V: Make static QRegularExpression instances static constAlessandro Portale2024-11-201-2/+2
| | | | | Change-Id: I291e61ac30786dfceda330d3dc73352da719c7d0 Reviewed-by: hjk <[email protected]>
* Plugins: Improve display names of pluginsAlessandro Portale2024-11-191-0/+1
| | | | | | | | | | | This introduces a field "DisplayName" to PluginSpec and the plugin spec json files. If present in the spec, PluginSpec::displayName returns it, or otherways falls back to more established fields. Fixes: QTCREATORBUG-31761 Change-Id: I4f4c4f3e33b17dfb2ec63644b1f50b3b9c6c024a Reviewed-by: Leena Miettinen <[email protected]> Reviewed-by: Eike Ziller <[email protected]>
* Unify copyright string and remove yearEike Ziller2024-09-261-1/+1
| | | | | | | | | | | The year is not needed and requires us to update it manually each year. So just remove it. Centralize it in the branding file to avoid changes to be done at lots of places (About dialog, plugin specs, app info plist & rc, docs, ...) in the future. Task-number: QTCREATORBUG-30432 Change-Id: Ia421924c19a1331b121e765bcea137920025598d Reviewed-by: Marcus Tillmanns <[email protected]>
* VcsBase: Fix a crash on shutdownJarek Kobus2024-09-121-1/+1
| | | | | | | | | | | | | | | | | | Since GitClient is a static object, it's being deleted after the git plugin is unloaded. We can't make it a parent of VcsCommand instances, as the process reaper may be already gone. Use ExtensionSystem::shutdownGuard() as a parent for VcsCommand instances instead. This commit reverts d5e8f70192494859b36b5539ab063e2cc0fdd896. Amends d5e8f70192494859b36b5539ab063e2cc0fdd896 Fixes: QTCREATORBUG-31549 Change-Id: I27e6abbfcac2746e8fa4c447010aab43c11444a9 Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: André Hartmann <[email protected]>
* Mercurial: Replace "SHA1" with "hash" in commentsAndre Hartmann2024-09-091-1/+1
| | | | | Change-Id: I25ae8320f97e7c1cb58870b63ff82188a7d22eb6 Reviewed-by: Orgad Shaneh <[email protected]>
* ProjectExplorer: Add VCS log for selected directoryAndre Hartmann2024-09-081-0/+3
| | | | | Change-Id: Ie4ad575eaa4cd1adea1e10a65dc04f1aa945b300 Reviewed-by: Orgad Shaneh <[email protected]>
* VCS: Unify displayName()Andre Hartmann2024-09-061-6/+1
| | | | | | | | | | | | * Uppercase first letter or whole name * Do not translate the name * Move implementation to declaration to immediately see all names in Find Usages Change-Id: I45f9b8bd8cfab46ab72548d22b140169880fe81f Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: Eike Ziller <[email protected]> Reviewed-by: Oswald Buddenhagen <[email protected]>
* ExtensionSystem: Add PluginId and VendorIdMarcus Tillmanns2024-09-021-0/+2
| | | | | Change-Id: I4f47f95e1f4ff4af73c2b81320087b4592007993 Reviewed-by: Alessandro Portale <[email protected]>
* Plugins: Add URLs to manual page to plugin metadataAlessandro Portale2024-07-291-0/+1
| | | | | | Fixes: QTCREATORBUG-31199 Change-Id: Ideadc75499f32a8f1d1c95cd38dc4669a3d422c3 Reviewed-by: Eike Ziller <[email protected]>
* Remove #include <utils/fileutils.h> from most header fileshjk2024-07-261-0/+1
| | | | | | | | | | It has some platform specific warts, filepath.h is somewhat cheaper and less ugly overall. Partially clean up surroundings Change-Id: Ida1fd470ec020f69c446109427f92a08e879789f Reviewed-by: Jarek Kobus <[email protected]>
* Plugin meta data: Add full stop to descriptionsEike Ziller2024-06-281-1/+1
| | | | | | | | | Where they were missing. The text is shown as a paragraph in the extension manager. Change-Id: I6e15c89fe4023b222e9c476f4312e13fcb0905c0 Reviewed-by: Leena Miettinen <[email protected]> Reviewed-by: Alessandro Portale <[email protected]>
* VCS: Improve performance of isVcsFileOrDirectory implementationsDavid Schulz2024-06-101-2/+3
| | | | | | | | | | FilePath operations are relative expensive on Windows compared to the cost of a string comparison, so always first check the file name before checking any file meta data. Change-Id: Ibb4c13d7e11e0c01bdf3706a62362f4c0a27d284 Reviewed-by: Eike Ziller <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* VCS: Fix handling of default executableChristian Stenger2024-06-041-1/+1
| | | | | | | | | | | | | | We set the executable by default to a single command which should be used as found in PATH. Although listed valid in settings some commands refuse to run when we validate the command before running without taking their full path into account. Use the full path of vcs binaries internally to avoid problems but still display single command if set. Change-Id: If8677b531c5534d27c19557ed36fa780a248558f Reviewed-by: Marcus Tillmanns <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* Mercurial: Fix history keyChristian Stenger2024-06-031-1/+1
| | | | | | Change-Id: I3e0606639402808c5ef9fe6e4d6af83118b041bb Reviewed-by: hjk <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* Add long descriptions to some pluginsLeena Miettinen2024-05-311-1/+5
| | | | | | | | | | | | Edited the short descriptions to answer the question "What can I do with this extension" to help users decide whether they need it. In long descriptions, tell users what else they need to be able to use the plugin. Change-Id: Iefce7505b61fc77cf38cc915f1f7dbd25c9cb570 Reviewed-by: Eike Ziller <[email protected]>
* PluginSpecs: Change URLs from http:// to https://Alessandro Portale2024-05-281-1/+1
| | | | | | | | | | Avoid the redirect that is inevitable nowerdays. Also, change necessitas.kde.org to www.qt.io, since the orgininal page is offline. Change-Id: Ib1823f0df97d2df87822fd2bb7552e2f2c7e971e Reviewed-by: Tim Jenssen <[email protected]>
* Fix QMetaType::type() related deprecation warningshjk2024-05-231-3/+3
| | | | | | | Not in sdktool, which still builds with Qt 5.15 Change-Id: I6e6f4331127b821e471e2840e7959cd65e6419e9 Reviewed-by: Eike Ziller <[email protected]>
* CommandLine: Reuse new c'torJarek Kobus2024-05-221-3/+1
| | | | | | Change-Id: Id154881b4f5d8c488e5c1f5e0f843d36bf838759 Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: <[email protected]>
* Merge remote-tracking branch 'origin/13.0'Eike Ziller2024-03-201-3/+2
|\ | | | | | | | | | | | | | | | | | | Conflicts: cmake/QtCreatorIDEBranding.cmake doc/qtcreator/src/overview/creator-only/creator-keyboard-shortcuts.qdoc qbs/modules/qtc/qtc.qbs src/plugins/remotelinux/linuxdevicetester.cpp Change-Id: I8434e41dcfbb50f6ed032a3e0af1591eb19b79eb
| * VcsBaseClientImpl: Don't leak VcsCommand instancesJarek Kobus2024-03-181-3/+2
| | | | | | | | | | | | | | | | | | The running VcsCommand may leak on shutdown. Make them always a child of a guard object. Change-Id: Ie2d07d15cd13f1c08636bb1e9c5face09c6a782d Reviewed-by: <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* | Utils: Fix build with MSVC with C++20Eike Ziller2024-02-281-1/+1
|/ | | | | | | | | | | | | | | | | Rename process.h back to qtcprocess.h MSVC's "threads" standard header includes <process.h>, and that ends up including our process.h from Utils. There already was a hacky workaround in place for a similar issue with MINGW, but that doesn't work with MSVC because that doesn't have Simply use a name that doesn't conflict. Change-Id: I1159cd2096b4f2dbc4a1728d0131dd6edd30ebd3 Reviewed-by: Qt CI Bot <[email protected]> Reviewed-by: <[email protected]> Reviewed-by: hjk <[email protected]>
* Fix i18n issuesEike Ziller2024-02-211-4/+4
| | | | | | | | Fix some missing Tr::, and some namespace usages that confused lupdate. Change-Id: Ib5a411fc53a28a6b807600db50aacc68955ca5dc Reviewed-by: hjk <[email protected]> Reviewed-by: Leena Miettinen <[email protected]>
* Mercurial: Remove unused lambda capturesJarek Kobus2024-02-141-3/+3
| | | | | Change-Id: I5b308dc57b10624d140ed506a17ed41b3ec49491 Reviewed-by: Orgad Shaneh <[email protected]>
* VCS: Allow remote vcs operationsMarcus Tillmanns2024-02-122-4/+5
| | | | | | | | | | | | | | | | Both VcsBaseClient::vcsBinary() and VcsBaseClient::processEnvironment() get an additional parameter "FilePath target" to allow selecting binaries and environment based on where the repository is located. This allows to select e.g. a git binary on a remote device, and the environment of the remote device for each VCS operation. A bunch of file path operations are either fixed or ported to actually use FilePath correctly. Change-Id: I6afc645772fde3dff3ec19c13efe538e5888e952 Reviewed-by: hjk <[email protected]> Reviewed-by: Orgad Shaneh <[email protected]>
* Vcs: Hide topic cache in new IVersionControl pimplhjk2024-02-091-18/+6
| | | | | | | | | Potentially more stable api long-term. Also simplifies the user side code a bit. Change-Id: I6913e27e2a5dc14907e72f252081cdbed34842a3 Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: <[email protected]>
* Vcs: Use QString and Id in editor parameters instead of char *hjk2024-02-092-10/+5
| | | | | | | | ... and use it to simplify the translation setup. Change-Id: Ibd386ede3ecfc351316bed53bc184954adbcaa74 Reviewed-by: Orgad Shaneh <[email protected]> Reviewed-by: <[email protected]>
* VCS: Simplify VcsEditor setuphjk2024-02-071-30/+18
| | | | | | | | | Create the editor parameter structures in-place, and also include the other two parameters in the struct to simplify the signature of the c'tor. Change-Id: Iff7d5ddf3096f4a3ed18e53265ae74806823af32 Reviewed-by: Orgad Shaneh <[email protected]>
* Mercurial: Use more direct access to the client singletonhjk2024-02-075-56/+60
| | | | | Change-Id: I32711a893bc5d5d655cf92637defaaf149f3f108 Reviewed-by: Orgad Shaneh <[email protected]>
* Vcs: Move VcsEditorFactory closer to its producthjk2024-02-071-1/+0
| | | | | Change-Id: Iaf2e6bdb4f04f0f1314ca7725feb63394a693511 Reviewed-by: Orgad Shaneh <[email protected]>
* Vcs: Merge basevcssubmiteditorfactory.* into vcsbasesubmiteditor.*hjk2024-02-071-1/+0
| | | | | | | Not worth a separate translation unit anymore. Change-Id: I579c81c811cd84d89fd39755dca2fbeffae017de Reviewed-by: Orgad Shaneh <[email protected]>
* Vcs: Make submit editor setup a bit more compacthjk2024-02-071-13/+8
| | | | | Change-Id: I14c4c51a456f7b3b04b79b63b476f89eb58d3ea0 Reviewed-by: Orgad Shaneh <[email protected]>
* Vcs: Rename VcsBasePluginPrivate to VersionControlBasehjk2024-02-061-4/+4
| | | | | | | | | | | The classes derived from this had a dual role of implementing the version control interface (IVersionControl) and as the plugin pimpls. The name was focusing on the latter, but plugin pimpls are being phased out in the new 'setupFoo()' world, so only the version control interface part remains. Change-Id: I60396f1729c736bc6c9e4fca250a5926e9d60f51 Reviewed-by: Orgad Shaneh <[email protected]>
* Utils: Also rename parameteraction.{h,cpp} to action.{h,cpp}hjk2024-01-291-1/+1
| | | | | | Change-Id: I203909d9b2d460012b9347d507ac7a701700c48a Reviewed-by: <[email protected]> Reviewed-by: Eike Ziller <[email protected]>
* Utils: Rename ParameterAction into Actionhjk2024-01-291-14/+14
| | | | | | | | It became the defacto-type for action when ActionBuilder started creating them as default. Change-Id: I1008d60b78ea83919ce1c80a7ef828527fe9902c Reviewed-by: Eike Ziller <[email protected]>
* Mercurial: Get rid of unused extraOptions argJarek Kobus2024-01-162-11/+5
| | | | | | | Simplify the implementation of showDiffEditor(). Change-Id: I0b5a2c1783d0e1723322208276c2a71554d55ea8 Reviewed-by: Orgad Shaneh <[email protected]>
* Mercurial: Get rid of a fake overloadJarek Kobus2024-01-163-8/+8
| | | | | | | | | The only callers are coming from the Mercurial plugin. The overload doesn't call the base implementation. So, there is no relation to the base impl. Change-Id: I718e3ab196e9df77f6682b3230a8739db58c0238 Reviewed-by: Orgad Shaneh <[email protected]>
* Mercurial: Hide plugin class definion in .cpphjk2024-01-154-52/+43
| | | | | Change-Id: I027e058eb555a3b4ccc06eaa11c8e0ecf38f51e2 Reviewed-by: Orgad Shaneh <[email protected]>
* Work on lambdas C++20 compatibilitySerg Kryvonos2023-12-131-1/+1
| | | | | Change-Id: I0d391c02ae1e1c5a1751b33ca7e83902e1cfe269 Reviewed-by: hjk <[email protected]>
* BaseAnnotationHighlighter: Get rid of QTextDocument arg from c'torJarek Kobus2023-11-212-5/+3
| | | | | | | It's always nullptr. Change-Id: Ia392b826f0afe8562b90b916722c374c5244d9aa Reviewed-by: Jarek Kobus <[email protected]>
* SyntaxHighlighter: Make setChangeNumbers private functionArtem Sokolovskii2023-11-213-7/+5
| | | | | | | | | | | | | Made setChangeNumbers private function in BaseAnnotationHighlighter and remove usage in other places. Moved annotationChanges to BaseAnnotationHighlighterPrivate from VcsBaseEditorWidget. This was done to move all instances of TextEditor::SyntaxHighlighter. In this regards only the public API of TextEditor::SyntaxHighlighter should be available from children and no other additional functions. Change-Id: Ibece9476a810e13c8722839820d5c575b0808f03 Reviewed-by: Jarek Kobus <[email protected]>
* SyntiaxHighlighter: Move VCS highlighters creating to TextDocumentArtem Sokolovskii2023-11-202-4/+3
| | | | | Change-Id: I531b30d31fb630d2292eaf4d8c61ff1e95fed460 Reviewed-by: Jarek Kobus <[email protected]>