aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/qmlprofiler
Commit message (Collapse)AuthorAgeFilesLines
* RunWorker: Merge RecipeRunner with RunWorkerJarek Kobus2025-04-282-2/+2
| | | | | | | | Make RunWorker final. Task-number: QTCREATORBUG-29168 Change-Id: Ic755ddd823f05e033a107667eca6c3e78f58992d Reviewed-by: hjk <[email protected]>
* Fix warning for ';'Marco Bubke2025-04-151-1/+1
| | | | | | | | The macro already contain a ';'. Removing the argument or [[maybe_unused]] would maybe even a better approach. Change-Id: I31750d10a4f252c667e7c0e5e13bf1085dbe11a2 Reviewed-by: hjk <[email protected]>
* Utils: Replace Result class by type alias to std::expected<T, QString>hjk2025-04-111-1/+1
| | | | | | | | | | | | | | ... to be able to conveniently return also non-void cases without being exposed to the syntax of expected. The price for the more general approach is some uglification of the void case: The previous 'Result' is now equivalent to 'Result<>', which needs to be spelled out in function signatures, and some changes to the special cases. Change-Id: Ic5026e237ef2077a0765cdb8287122cae99d699f Reviewed-by: Marcus Tillmanns <[email protected]> Reviewed-by: Eike Ziller <[email protected]>
* Transform ProcessRunner into RecipeRunnerJarek Kobus2025-04-101-11/+7
| | | | | | | Task-number: QTCREATORBUG-29168 Change-Id: Ia0c606e6742fb5db9cb6907a3b9cf3772462b321 Reviewed-by: Christian Kandeler <[email protected]> Reviewed-by: hjk <[email protected]>
* QmlProfiler: Code cosmeticshjk2025-04-1064-244/+186
| | | | | | | Namespaces, #includes, whitespace, QVector->QList... Change-Id: Ibbdcb28df99f0f65b95362275ac74adec96d65d0 Reviewed-by: Christian Stenger <[email protected]>
* Merge remote-tracking branch 'origin/16.0'Eike Ziller2025-04-092-2/+3
|\ | | | | | | | | | | | | | | | | | | | | Conflicts: .github/workflows/build_cmake.yml coin/instructions/common_environment.yaml src/plugins/lua/bindings/texteditor.cpp src/plugins/qmlprofiler/qmlprofilerruncontrol.cpp src/plugins/qmlprofiler/qmlprofilertool.cpp Change-Id: I5cf84f47c4ce79b6e48d836e8fa083a656b0ce4b
| * Fix attaching QML Profiler to running applicationEike Ziller2025-04-072-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The QML channel to use (the port that the user specified in the dialog for attaching) was no longer set for the QmlProfilerRunner. That broke with a22e79f38c13b652ad9639ee810647fc0c0e96b0 Avoid the usage of the ports gatherer with QmlProfilerRunner for the attachToWaitingApplication case and set the qmlChannel manually. Also avoid soft assert if there is no active run configuration. Fixes: QTCREATORBUG-32617 Change-Id: I608cc736ed82284afbdd40277a54237f80f30306 Reviewed-by: Jarek Kobus <[email protected]>
* | ProcessRunner: Modify start modifier signatureJarek Kobus2025-04-041-5/+7
| | | | | | | | | | | | | | | | | | Pass reference to Process inside setStartModifier(). Get rid of ProcessRunner's setters. Task-number: QTCREATORBUG-29168 Change-Id: Ib2dac5a1fbb0a0a4706fbb03896aa302c75d012c Reviewed-by: hjk <[email protected]>
* | ProcessRunner: Get rid of commandLine() getterJarek Kobus2025-04-041-1/+1
| | | | | | | | | | | | | | | | Use RunControl::commandLine() instead. Task-number: QTCREATORBUG-29168 Change-Id: I855504110c07e0feb0e9a3556867f3e6d29c1d96 Reviewed-by: hjk <[email protected]>
* | RunWorkerFactory: Introduce setRecipeProducer()Jarek Kobus2025-03-311-3/+1
| | | | | | | | | | | | | | And reuse it. Change-Id: I6b12a7fd41b3e3bb116cab85a4458ea08e078b3b Reviewed-by: hjk <[email protected]>
* | QmlProfiler: Fix a crash on shutdown when waiting for connectionJarek Kobus2025-03-311-0/+6
| | | | | | | | | | | | | | | | Apparently the QmlProfilerTool::instance() might be nullptr on shutdown. Change-Id: I0a654184b92c96c43f60d675b21f82e2abca2319 Reviewed-by: hjk <[email protected]>
* | QmlProfiler: Simplify start modifierJarek Kobus2025-03-241-6/+3
| | | | | | | | | | Change-Id: I6c5ff94fbc60d080b9f5ca665bb00af8d22d371c Reviewed-by: hjk <[email protected]>
* | QmlProfiler: Dismantle QmlProfilerRunnerJarek Kobus2025-03-244-135/+48
| | | | | | | | | | | | | | | | Use RecipeRunner instead. Task-number: QTCREATORBUG-29168 Change-Id: I58ada985ecb1c9cdfc6668d0569d5b20f97bd449 Reviewed-by: hjk <[email protected]>
* | Avoid potential detach of non-const Qt containers in range-loops 1/2Alessandro Portale2025-03-211-1/+1
| | | | | | | | | | | | | | By making the containers const. Change-Id: I3095d7c817bd8a9cc40184aba144d617c6071f97 Reviewed-by: hjk <[email protected]>
* | QmlProjectManager: Hide SimpleQmlProfilerRunnerFactoryJarek Kobus2025-03-211-20/+1
| | | | | | | | | | | | | | | | Move it from QmlProfiler into QmlProjectManager and hide in cpp, as it's only used there. Change-Id: Ibad65ee83e71788cc010857f0790aca93cf78dcd Reviewed-by: hjk <[email protected]>
* | QmlPreview: Introduce setServer() setterJarek Kobus2025-03-182-9/+18
| | | | | | | | | | | | | | | | And remove arg from connectToServer(). This will ease the integration with TaskTree. Change-Id: Icdacef9a2d6a66773aab126511054c900a437954 Reviewed-by: hjk <[email protected]>
* | QmlProfiler: Code cosmetics in testshjk2025-03-1738-242/+193
| | | | | | | | | | Change-Id: I6fc455aae12c0c35ca6becae33013ad137799d00 Reviewed-by: Christian Stenger <[email protected]>
* | QmlProfiler: Fix QmlProfilerToolTesthjk2025-03-173-2/+5
| | | | | | | | | | | | | | | | The test crashed since the connection URL was not set anymore, and the default-constructed value caused an endless recursion in QmlProfilerToolTest(). Change-Id: Ib0e3cb89c236033754c0bb8007f57f8dc3364c19 Reviewed-by: Christian Stenger <[email protected]>
* | QtSupport: Use BuildConfiguration for populateQmlFileFinder()hjk2025-03-126-9/+10
| | | | | | | | | | | | | | Removes one use Target::deploymentData() Change-Id: I9e6177376b340d04eb2c8b6803826fbf0d278bd6 Reviewed-by: Christian Kandeler <[email protected]>
* | ProjectExplorer: Make run config aspects take a BuildConfigurationChristian Kandeler2025-03-112-2/+2
| | | | | | | | | | | | | | ... instead of a Target. Change-Id: Ia14917bd54a849c725efb90fc9f127822815c6c8 Reviewed-by: hjk <[email protected]>
* | QmlProfiler: Remove the usage of setAutoDeleteOnStop() in testsJarek Kobus2025-03-071-33/+19
| | | | | | | | | | | | | | | | Delete the RunControl manually instead. Ensure the RunControl is stopped before it's reset. Change-Id: I0cabdc613594c24054ab9e60cda0deca5595c96f Reviewed-by: hjk <[email protected]>
* | QmlProfiler: Fix expected messages to be receivedJarek Kobus2025-03-071-2/+2
| | | | | | | | | | | | | | | | | | | | It looks like the additional spaces were fixed in sources, but not in test. This makes LocalQmlProfilerRunnerTest::testRunner() to pass now. Change-Id: Ia8d6f35a440dea9034dba87fb3f7f8a3bcdca44f Reviewed-by: hjk <[email protected]>
* | ProjectExplorer: Re-add Runcontrol::target()Christian Kandeler2025-03-061-1/+1
| | | | | | | | | | | | | | | | Fixes a crash in LocalQmlProfilerRunnerTest, which uses an artificial setup without a build configuration. Change-Id: Ife43f765b80caea00ea146cdd14f2d60583ccc0c Reviewed-by: Jarek Kobus <[email protected]>
* | ProjectExplorer: Make run configurations per build configurationChristian Kandeler2025-03-061-1/+2
| | | | | | | | | | | | | | | | Fixes: QTCREATORBUG-20986 Task-number: QTCREATORBUG-32380 Change-Id: Id5bcb8fcc6d97375f15a1266ae040ea637df9683 Reviewed-by: hjk <[email protected]> Reviewed-by: Christian Stenger <[email protected]>
* | Android: Remove the usage of QmlOutputParserJarek Kobus2025-03-051-2/+0
| | | | | | | | | | | | | | | | | | | | Since we were not connected to its signals, the result of the parsing was ignored. Remove unneeded includes of qmloutputparser.h. Change-Id: I52cdf32de58e20a9e25f5e217af84db3ec440d4b Reviewed-by: Alessandro Portale <[email protected]>
* | Debugger: Simplify analyzer icon organizationhjk2025-02-211-3/+0
| | | | | | | | | | Change-Id: I7b7abe068ec608e6b659171b811bacc26c800a09 Reviewed-by: Alessandro Portale <[email protected]>
* | Merge remote-tracking branch 'origin/16.0'Orgad Shaneh2025-02-111-2/+2
|\| | | | | | | Change-Id: I85e9d3ec36f5cb0f7d213a9582e0e0841299c2b5
| * QmlProfiler: Fix sorting statisticsChristian Stenger2025-02-111-2/+2
| | | | | | | | | | | | Fixes: QTCREATORBUG-32398 Change-Id: Ib717df00a3aa45f9eda71bfd572adc06388a216f Reviewed-by: Ulf Hermann <[email protected]>
* | QmlProfiler: suppress GCC warning in array bounds for QmlEvent::numberThiago Macieira2025-01-241-0/+3
|/ | | | | | | qmlevent.h:99:42: warning: array subscript 2 is above array bounds of ‘const qint32 [2]’ {aka ‘const int [2]’} [-Warray-bounds=] Change-Id: I477e6dccebda4fbb81f6fffd1791163bd660f714 Reviewed-by: Ulf Hermann <[email protected]>
* ProjectExplorer: Add convenience accessors to some classesChristian Kandeler2025-01-231-1/+1
| | | | | | | | | | | | Namely, Kit, BuildConfiguration, BuildSystem and RunConfiguration get functions to retrieve the active instance for a given project as well as the one for the current and active projects, respectively. This saves a ton of annoying null pointer checks. Some of these functions replace existing ones with the same purpose that were scattered around the code base. Change-Id: I18247061229bbeb8b8ad1e15a2bd7a6626438bc0 Reviewed-by: hjk <[email protected]>
* Fix warnings about unused return valuesChristian Kandeler2025-01-211-1/+1
| | | | | Change-Id: I9682c6b5a0bba400050e91fe89b2883f7bb6465f Reviewed-by: Christian Stenger <[email protected]>
* QmlProfiler: Support re-runningJarek Kobus2025-01-151-1/+0
| | | | | Change-Id: Ia274f158be0c553dceb69fde4adafc4ee72e809f Reviewed-by: Ulf Hermann <[email protected]>
* RunWorker: Get rid of setSupportsReRunning()Jarek Kobus2025-01-151-1/+1
| | | | | | | Use RunControl::setSupportReRunning() instead. Change-Id: I7cfcf9cb3542756ab3d990a22b6224f390b7eed9 Reviewed-by: hjk <[email protected]>
* Utils: Rename FilePath::toString() into toUrlishString()hjk2025-01-103-7/+7
| | | | | | | | | | | | | | | | toString() is almost always the wrong conversion, but unfortunately too easy to find and often even working at least for local setup. This here raises the bar as the non-availability of the "obvious" toString() hopefully helps people to think about the semantics of the needed conversion and choose the right toXXX() function. The chosen new name is intentional ugly to reduce the likelihood that this (still almost always wrong) function is used out of convenience. Change-Id: I57f1618dd95ef2629d7d978688d130275e096c0f Reviewed-by: Eike Ziller <[email protected]>
* Fix missing includeEike Ziller2025-01-091-0/+1
| | | | | | | Amends 25d6dcc7be52229a67fd6d4bdde6092496907907 Change-Id: I157947c7570df4dbef36a0d8433bbb885d31d685 Reviewed-by: Jarek Kobus <[email protected]>
* QmlProfilerRunner: Drop private dataJarek Kobus2025-01-072-44/+16
| | | | | Change-Id: I8f45174cec9de3c88056bbe364da1f7c40820b36 Reviewed-by: hjk <[email protected]>
* QmlProfilerTool: Move parts of finalizeRunControl into QmlProfilerRunnerJarek Kobus2025-01-074-72/+67
| | | | | | | | Hide QmlProfilerRunner::cancelProcess(). Pass RunControl into finalizeRunControl, instead of QmlProfilerRunner. Change-Id: I3f57a8d80a6261bb5692715c0251a600d35b54ae Reviewed-by: hjk <[email protected]>
* QmlProfilerTool: Expose handleStop()Jarek Kobus2025-01-073-17/+20
| | | | | | Change-Id: I23cc902881899046580e83bc71810a73ca586c1b Reviewed-by: hjk <[email protected]> Reviewed-by: Ulf Hermann <[email protected]>
* Utils: Add CommandLine::toLocal()Jarek Kobus2025-01-071-2/+1
| | | | | | | And get rid of ProcessRunner::forceRunOnHost(). Change-Id: Ia2d0e526c59a474db0fb79d675b7acd0bf45f2ca Reviewed-by: hjk <[email protected]>
* QmlProfiler: Simplify QmlProfilerRunnerJarek Kobus2025-01-073-40/+13
| | | | | | | | | | | Remove registerProfilerStateManager() and connect to state manager's signal directly from the start() function. Remove Q_OBJECT macro. Change-Id: Id03486f077c81909fbe0889bb342ee7595631e9d Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: hjk <[email protected]>
* PE: Rename SimpleTargetRunner into ProcessRunnerJarek Kobus2025-01-061-1/+1
| | | | | Change-Id: Ie666fe0811aa63c54edf12934c6db4e17b26c252 Reviewed-by: hjk <[email protected]>
* Disambiguate translations for "All"Eike Ziller2025-01-062-5/+5
| | | | | | | | | Translations can be different depending on context. Give each usage a disambiguation text. Task-number: QTCREATORBUG-31978 Change-Id: I5fe854f96ce285943ff47993cd6d56db603d1c27 Reviewed-by: Christian Stenger <[email protected]>
* Disambiguate translations for "None"Eike Ziller2025-01-062-3/+3
| | | | | | | | | Translations can be different depending on context. Give each usage a disambiguation text. Task-number: QTCREATORBUG-31978 Change-Id: I44ac524d7448787360e825fad1d430ded3f07659 Reviewed-by: Christian Stenger <[email protected]>
* Utils: Remove parent argument from FileUtils dialogshjk2025-01-061-2/+2
| | | | | | | | | Some were using ICore::dialogParent() directly and the 'nullptr' users were using that implicitly, but quite a few actually effectively changed now from some local widget to (implicit) ICore::dialogParent(). Change-Id: Ibb2767b1289221dd26757361235ee88df4a1695e Reviewed-by: Eike Ziller <[email protected]>
* Merge remote-tracking branch 'origin/15.0'Eike Ziller2025-01-021-11/+14
|\ | | | | | | | | | | | | | | Conflicts: src/plugins/qmljseditor/qmljseditordocument.cpp src/plugins/qmljseditor/qmllsclient.cpp Change-Id: I0fce4ae6240a8f14257de8e134bceb6e64ddf4a5
| * QmlProfiler: Fix crash at startup if file creation failsEike Ziller2024-12-171-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If opening the temporary file for QmlProfilerEventStorage fails in it's destructor, it was crashing, because the error handler tried to emit a signal on an object that wasn't even half constructed yet. Can be tested by forcing the return value of TraceStashFile::open to `false`. Delay the construction of the event storage a bit and do not set the error handler in its constructor, since nobody could connect to the signal that was sent yet anyway. Also add some checks before calling the error handler. Change-Id: I0fc1207aac447090e12f6b2342e156312e0d1d1b Reviewed-by: hjk <[email protected]>
* | ProjectExplorer: Introduce a RunControl::start()hjk2024-12-201-1/+1
| | | | | | | | | | | | | | And use it in various places. Change-Id: I525d6fe89652ceba9f675b0b8c9e7ea6a8bcf4be Reviewed-by: Jarek Kobus <[email protected]>
* | Debugger/ProjectExplorer: Promote run configuration aspect widgetshjk2024-12-201-3/+5
| | | | | | | | | | | | | | | | | | | | | | These are the widgets at the bottom of the run config settings that share the ability to switch between a global and per-target setting. There is nothing inherently debugger specific here, except for the common history. Change-Id: I4c57c138bb05c2a505f1bac13161352417bd8fe4 Reviewed-by: Christian Kandeler <[email protected]>
* | Debugger: Merge analyzerconstants.h into debuggerconstants.hhjk2024-12-201-1/+1
| | | | | | | | | | Change-Id: Id092c8d0bedad987e963b36b0e9b46e7182209a2 Reviewed-by: Jarek Kobus <[email protected]>
* | Debugger: Merge analyzermanager.h into analyzerutils.hhjk2024-12-204-4/+5
| | | | | | | | | | | | | | | | | | ... and put everything into namespace Debugger. The analyzer/debugger separation is long gone. Change-Id: Ife819b0bc4add4a6f7a81b0a8a20dcbf7282125f Reviewed-by: Jarek Kobus <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2025-05-14 08:22:20 +0000