| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Avoid mangled id.
Change-Id: I4b42813366d4c58ec50fe77581d5a0828fbdff81
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
| |
... and remove Q_OBJECT and now unneeded pimpl.
Change-Id: I4ea53a6089a5a3c23cc7118e56a4665a46c407e8
Reviewed-by: Christian Kandeler <[email protected]>
|
|
|
|
|
|
|
| |
The pattern we tend use elsewhere for singletons.
Change-Id: I96509f7bb174b593edd1d8f53ac50fa2e8d05dbc
Reviewed-by: Christian Kandeler <[email protected]>
|
|
|
|
|
|
|
|
| |
Using a BoolAspect allows us to set it as an enabler on the PrivateKeyFile
aspect.
Change-Id: Ief61526d65d3c2c2bdfe8e2773404ccb701dc525
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I1619426fcbaf5ca909abe7d57d4289de407c2830
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I561342c64e6baa612c25cb09cc45aac8e94bed01
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
| |
... with stderr/stdout data, if requested.
Change-Id: Ia4aed9b342144d5358c5a91f4555bccb86b2eb7b
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-29168
Change-Id: I101fdc1589d36ff996eef12308cf4165143b04af
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I38faa3be91e615571f02d51a721ea858b5f70298
Reviewed-by: Christian Kandeler <[email protected]>
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-29168
Change-Id: I0ea10bc6e9e4ce0be1e6653559f11f750c0e5ce9
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
|
| |
SshProcessInterfacePrivate::fullLocalCommandLine() will already add the
sourcing itself. No need to add it manually again.
Fixes QNX devices mostly.
Change-Id: I552a432f5adf367318444e6c6dff815fed67d9a7
Reviewed-by: Christian Kandeler <[email protected]>
|
|
|
|
|
|
|
|
| |
Keep it in Axivion dto, which is generated.
Change-Id: I83a12de6234ac7b0218b369875bdc72d25dbadfb
Reviewed-by: Eike Ziller <[email protected]>
Reviewed-by: Jarek Kobus <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
... to be able to conveniently return also non-void cases without being
exposed to the syntax of expected.
The price for the more general approach is some uglification of the
void case: The previous 'Result' is now equivalent to 'Result<>',
which needs to be spelled out in function signatures, and some
changes to the special cases.
Change-Id: Ic5026e237ef2077a0765cdb8287122cae99d699f
Reviewed-by: Marcus Tillmanns <[email protected]>
Reviewed-by: Eike Ziller <[email protected]>
|
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-29168
Change-Id: Ia0c606e6742fb5db9cb6907a3b9cf3772462b321
Reviewed-by: Christian Kandeler <[email protected]>
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: Ib809a0699bbba55b8fbd6d6a11f4083ca3c2dafc
Reviewed-by: Leena Miettinen <[email protected]>
|
|
|
|
|
|
| |
Fixes: QTCREATORBUG-32450
Change-Id: If3c265bd74139f97ad921eb377d62b8943f49fdb
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Pass reference to Process inside setStartModifier().
Get rid of ProcessRunner's setters.
Task-number: QTCREATORBUG-29168
Change-Id: Ib2dac5a1fbb0a0a4706fbb03896aa302c75d012c
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
| |
Use RunControl::commandLine() instead.
Task-number: QTCREATORBUG-29168
Change-Id: I855504110c07e0feb0e9a3556867f3e6d29c1d96
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Docker containers often come with custom entry point scripts that inject
Environment variables into the shell. Since our bridge and other custom
processes are not spawned via the entry point they don't automatically
get access to the variables, breaking the KitDetector or the Terminal if
the user hopes to have them set.
As a workaround, we run "printenv" when a device is created and store
the output in its settings. We then use this environment as the device
environment when creating processes.
For old configs, we fetch the environment in fromMap in case it is not
set.
Fixes: QTCREATORBUG-32135
Change-Id: I16c04d391907698fd9f66fc3d33d068accb8054a
Reviewed-by: hjk <[email protected]>
|
|\
| |
| |
| | |
Change-Id: I466d212f57f706c71fd0c2624abb33814ea3e783
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is an interesting message in case the user misconfigured something,
but in cases where this is expected, like Boot2Qt on macOS where the
Docker build device does not support rsync or sftp, it is rather
confusing if this looks like an error.
Task-number: QTCREATORBUG-30831
Change-Id: I8f9be849c5c409189f3f7dea266b926aa23928e0
Reviewed-by: hjk <[email protected]>
|
| |
| |
| |
| |
| | |
Change-Id: I9fec40386ffddedede24897e88f31c5c29ae44bb
Reviewed-by: hjk <[email protected]>
|
| |
| |
| |
| |
| |
| |
| | |
... in BuildStepList::StepCreationInfo.
Change-Id: I7732f2979c538b022eed7d52febd526695563671
Reviewed-by: hjk <[email protected]>
|
| |
| |
| |
| |
| |
| |
| | |
... when decorating names.
Change-Id: I157ea7f1453a1a40e49aa76971b837e1aec24872
Reviewed-by: hjk <[email protected]>
|
| |
| |
| |
| |
| | |
Change-Id: I8fe34a0fe4c61d5f52fa53718b3c872d16b6e842
Reviewed-by: hjk <[email protected]>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
... with ones of BuildConfiguration and BuildSystem.
This change handles the obvious cases. The remaining contexts have the
Target class as their central component and need closer examination.
Change-Id: I05963a5d7924c8f0f348ebf8fc00cddfda4a43bc
Reviewed-by: hjk <[email protected]>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes: QTCREATORBUG-20986
Task-number: QTCREATORBUG-32380
Change-Id: Id5bcb8fcc6d97375f15a1266ae040ea637df9683
Reviewed-by: hjk <[email protected]>
Reviewed-by: Christian Stenger <[email protected]>
|
|/
|
|
|
|
|
| |
... with more suitable ones in the respective context.
Change-Id: Ia6e09f4dbbf18a324f96bb7e05ff9f7d82a38a5e
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I4de249944f8efcbaf4d3ad3980c33b3bbb3fc5b9
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: Iae53f4c3948176f0bc5df11d2cc24b33c113d774
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I84c486f310c0170ed3d0aa65811e61034c1650e4
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
| |
Use Result instead.
Task-number: QTCREATORBUG-27363
Change-Id: Ieabd897289496b38568ffb72a9a3e7b802a28682
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I3b226fa7c89fd033bb02d425bd93e27e40cdd676
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: I2a58266071dccad63d762cf6b6e852efa6b7a4e9
Reviewed-by: Christian Kandeler <[email protected]>
|
|
|
|
|
| |
Change-Id: I7f9dc2720f115fa921aff74368e8d7eb80b2d34c
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
| |
Inside DeviceProcessSignalOperation::finished() signal.
Task-number: QTCREATORBUG-27363
Change-Id: Iea1aced1105daf8f60e23d35466e0173d4e3669b
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
| |
Call setUseTerminal() instead.
Change-Id: I2ef6fb1437cd0cfcaee39bcaeeeb1f887a01a34f
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
| |
Into DebuggerRunParameters.
Change-Id: I7fc0d32fd10604c8a7fd13e0e4348ed35af1bf06
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
| |
Move fields into DebuggerRunParameters.
Change-Id: Ieb43aede46a6a401da06dbbf2cd43d71ba56fed3
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: Icfb8e7bdba1ba44fb64cc80ef9a2c20e59df755c
Reviewed-by: Jarek Kobus <[email protected]>
|
|
|
|
|
|
|
|
| |
Merge setIosPlatform() into setLldbPlatform().
Task-number: QTCREATORBUG-29168
Change-Id: Ib29e291921fd0b64076df6ddbe2aaa1ffa3adc07
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-29168
Change-Id: I9e009b0e1a503a810ed412ac02c4706948c22e88
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toString() is almost always the wrong conversion, but unfortunately
too easy to find and often even working at least for local setup.
This here raises the bar as the non-availability of the "obvious"
toString() hopefully helps people to think about the semantics of
the needed conversion and choose the right toXXX() function.
The chosen new name is intentional ugly to reduce the likelihood
that this (still almost always wrong) function is used out of
convenience.
Change-Id: I57f1618dd95ef2629d7d978688d130275e096c0f
Reviewed-by: Eike Ziller <[email protected]>
|
|
|
|
|
|
| |
Task-number: QTCREATORBUG-29168
Change-Id: I238bd63ca48acb979ff4d6befed7981b620d712b
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The focus is on DebuggerRunParameters and DebuggerRunTool
API change. The rest is an adaptation.
The pattern would be:
1. Move a setter from DebuggerRunTool into DebuggerRunParameters.
2. Provide a corresponding getter.
3. Prefix a field with "m_".
4. Move the field into private section.
Transform only one field in this patch to avoid giant change.
Most probably one patch for one transformation could be optimal.
Task-number: QTCREATORBUG-29168
Change-Id: Idc46fc78a16889f4de09c8718d1bc9ad28ad3df1
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Get rid of qmlChannel() / usesQmlChannel() indirections.
This is RunControl's responsibility, so use the
corresponding methods of run control directly.
Change-Id: I0681c66358cc0cf8bfcb8be4ea2dbe3dad949dff
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
| |
Change-Id: Ie666fe0811aa63c54edf12934c6db4e17b26c252
Reviewed-by: hjk <[email protected]>
|
|
|
|
|
|
|
|
|
| |
Some were using ICore::dialogParent() directly and the 'nullptr' users
were using that implicitly, but quite a few actually effectively changed
now from some local widget to (implicit) ICore::dialogParent().
Change-Id: Ibb2767b1289221dd26757361235ee88df4a1695e
Reviewed-by: Eike Ziller <[email protected]>
|
|
|
|
|
|
|
| |
When requested. Otherwise, the user PATH settings are not picked up.
Change-Id: Iaeb2af524832d3e5f393527140c72b298d6250f8
Reviewed-by: Christian Kandeler <[email protected]>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is getting into the way for remote builds as it disabled
the GenericCopy version which is in principle always usable.
Make this even the preferred version for the build == run case,
as this will end up in the fast path of FilePath::copyFile.
As a collateral improvement this also removes the error message
that was referring to rsync only.
Change-Id: Ia27e3733b99f0de0161050c0355f135026b899f5
Reviewed-by: Christian Kandeler <[email protected]>
|