This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Fixing flaky tests in DateTest4_indian and DateTest5_iso8601#2148
Merged
wenshao merged 1 commit intoalibaba:masterfrom Dec 10, 2018
Merged
Fixing flaky tests in DateTest4_indian and DateTest5_iso8601#2148wenshao merged 1 commit intoalibaba:masterfrom
wenshao merged 1 commit intoalibaba:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
============================================
- Coverage 81.67% 81.66% -0.02%
+ Complexity 6784 6780 -4
============================================
Files 140 140
Lines 25360 25360
Branches 6055 6055
============================================
- Hits 20713 20709 -4
- Misses 2930 2931 +1
- Partials 1717 1720 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_date in DateTest4_indian and DateTest5_iso8601 has a test-order dependency and it fails when they are run by themselves.
test_date can be fixed by running a setup to change the time and locale to "Asia/Shanghai" and "China" (respectively). This setup is the same as the one in the DateTest class that these tests were depending on. The fix will enable test_date in the two classes to now pass in any test run order and by itself. Without the fix, the tests will get the following error. Let me know if you want to discuss more.