Skip to content

Move from gopkg to gomod and newer dependencies #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 3 commits into from
Jan 29, 2020
Merged

Move from gopkg to gomod and newer dependencies #133

k8s-ci-robot merged 3 commits into from
Jan 29, 2020

Conversation

@barney-s
Copy link
Contributor

@barney-s barney-s commented Jan 17, 2020

  1. Move from gopkg to gomod
  2. Remove vendor folder
  3. Pull in newer controller-gen tooling

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 17, 2020
@barney-s barney-s requested review from janetkuo and mortent January 17, 2020 02:11
@barney-s barney-s mentioned this pull request Jan 17, 2020
Merged
@mortent
Copy link
Member

mortent commented Jan 17, 2020

Can we remove the two commits that touch the OWNERS files from the PR? Also, the title of the PR needs to be changed before we merge.

Have we verified that the generated Application CRD definition remains unchanged after this PR?

@barney-s
Copy link
Contributor Author

barney-s commented Jan 21, 2020

@mortent
There is no change in CRD

Also removed the commits touching OWNERS file.

@mortent
Copy link
Member

mortent commented Jan 22, 2020

/lgtm
We also need to remove WIP from the title before we merge. Not sure why the invalid-owners-file label is still set.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2020
@barney-s barney-s changed the title [WIP] Move from gopkg to gomod and newer dependencies Move from gopkg to gomod and newer dependencies Jan 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020
@janetkuo
Copy link
Member

janetkuo commented Jan 24, 2020

/verify-owners

@barney-s
Copy link
Contributor Author

barney-s commented Jan 27, 2020

@janetkuo @kow3ns - would you please approve this ?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020
@barney-s
Copy link
Contributor Author

barney-s commented Jan 28, 2020

/verify-owners

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 28, 2020
@barney-s
Copy link
Contributor Author

barney-s commented Jan 28, 2020

@mortent do you mind LGTM'ing again

@mortent
Copy link
Member

mortent commented Jan 28, 2020

Why did we merge master into this branch? And it looks like this will remove you from the reviewers and approvers lists. Didn't you just update them?

@barney-s
Copy link
Contributor Author

barney-s commented Jan 28, 2020 •
edited
Loading

Why did we merge master into this branch? And it looks like this will remove you from the reviewers and approvers lists. Didn't you just update them?

There was a merge conflict post travis/e2e test merges.
Will fix the owners file.
I had used the github UI's merge button that caused a commit. Now i rebased my branch and removed the conflicts and preserved OWNERS_ALIASES

@mortent
Copy link
Member

mortent commented Jan 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit b07732c into kubernetes-sigs:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janetkuo janetkuo janetkuo approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@pwittrock pwittrock Awaiting requested review from pwittrock

@mortent mortent Awaiting requested review from mortent

Assignees

@mortent mortent

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barney-s @mortent @janetkuo @k8s-ci-robot