-
Notifications
You must be signed in to change notification settings - Fork 70
feat(agent): Add instrumentation for aws kinesis data streams #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zsistla
wants to merge
8
commits into
dev
Choose a base branch
from
feat/aws_kinesis_data_streams
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instrument kinesis data stream putRecord(producer), putRecords(producer), getRecords(consumer) as new message segments. Required new library kinesis and new platform aws_kinesis_data_streams. Add unit tests
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1137 +/- ##
==========================================
- Coverage 78.40% 78.33% -0.08%
==========================================
Files 193 193
Lines 28067 28146 +79
==========================================
+ Hits 22007 22048 +41
- Misses 6060 6098 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ZNeumann
reviewed
Dec 3, 2025
ZNeumann
reviewed
Dec 3, 2025
ZNeumann
reviewed
Dec 3, 2025
ZNeumann
reviewed
Dec 3, 2025
…ewrelic-php-agent into feat/aws_kinesis_data_streams
ZNeumann
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec, aws kinesis data streams should be instrumented as message segments.
aws-sdk-php kinesisClient src: https://github.com/aws/aws-sdk-php/tree/master/src/Kinesis