Skip to content

Conversation

@zsistla
Copy link
Contributor

@zsistla zsistla commented Dec 1, 2025

According to spec, aws kinesis data streams should be instrumented as message segments.

  1. Add new NR_MESSAGE_DESTINATION_TYPE_STREAM “Stream” to message_segment
  2. Instrument kinesis data stream putRecord(producer), putRecords(producer), getRecords(consumer) as new message segments. Required new library kinesis and new platform aws_kinesis_data_streams.
  3. Add unit tests

aws-sdk-php kinesisClient src: https://github.com/aws/aws-sdk-php/tree/master/src/Kinesis

Instrument kinesis data stream putRecord(producer), putRecords(producer), getRecords(consumer) as new message segments.  Required new library kinesis and new platform aws_kinesis_data_streams.
Add unit tests
@zsistla zsistla added this to the next-release milestone Dec 1, 2025
@zsistla zsistla requested a review from ZNeumann December 1, 2025 18:56
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Dec 1, 2025

Test Suite Status Result
Multiverse 15/16 passing
SOAK 0/0 passing

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 51.89873% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.33%. Comparing base (3c10f6e) to head (837fdc6).

Files with missing lines Patch % Lines
agent/lib_aws_sdk_php.c 50.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1137      +/-   ##
==========================================
- Coverage   78.40%   78.33%   -0.08%     
==========================================
  Files         193      193              
  Lines       28067    28146      +79     
==========================================
+ Hits        22007    22048      +41     
- Misses       6060     6098      +38     
Flag Coverage Δ
agent-for-php-7.2 78.39% <100.00%> (+<0.01%) ⬆️
agent-for-php-7.3 78.40% <100.00%> (+<0.01%) ⬆️
agent-for-php-7.4 78.26% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.0 77.76% <100.00%> (+<0.01%) ⬆️
agent-for-php-8.1 77.99% <51.89%> (-0.08%) ⬇️
agent-for-php-8.2 77.61% <51.89%> (-0.08%) ⬇️
agent-for-php-8.3 77.61% <51.89%> (-0.08%) ⬇️
agent-for-php-8.4 77.62% <51.89%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lavarou lavarou modified the milestones: 12.2.0, next-release Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants