Skip to content

feat(agent): Add instrumentation for aws kinesis data streams #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
+744 −6
Open

feat(agent): Add instrumentation for aws kinesis data streams #1137

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d7dc5d
feat(agent): Add new NR_MESSAGE_DESTINATION_TYPE_STREAM “Stream” to m…
zsistla Dec 1, 2025
965896a
feat(agent): aws-sdk-php kinesis data stream instrumentation
zsistla Dec 1, 2025
39071ea
fix: cloud.platform
zsistla Dec 1, 2025
0c0064b
Merge branch 'dev' into feat/aws_kinesis_data_streams
zsistla Dec 1, 2025
47921b7
fix: Add additional tests and fix a comment
zsistla Dec 3, 2025
39c217c
Merge branch 'feat/aws_kinesis_data_streams' of github.com:newrelic/n…
zsistla Dec 3, 2025
260dfb8
fix: update test descriptions
zsistla Dec 3, 2025
837fdc6
fix: revert change
zsistla Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update test descriptions
  • Loading branch information
@zsistla
zsistla committed Dec 3, 2025
commit 260dfb8b3f8fe8c07c3bdeb25a299b84fff19629
27 changes: 14 additions & 13 deletions agent/tests/test_lib_aws_sdk_php.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,68 +673,69 @@ static void test_nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn() {
&cloud_attrs);
tlib_pass_if_null("empty stream_arn, cloud_resource_id should be null.",
cloud_attrs.cloud_resource_id);
tlib_pass_if_null("null stream_arn, destination_name should be null.",
tlib_pass_if_null("empty stream_arn, destination_name should be null.",
message_params.destination_name);

/* Test null message_params, null arn. No values extracted, shouldn't modify
* cloud_attrs. */
nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(NULL, NULL,
&cloud_attrs);
tlib_pass_if_null(
"null stream_arn and null arn, cloud_resource_id should be null.",
"null message_params and null arn, cloud_resource_id should be null.",
cloud_attrs.cloud_resource_id);

/* Test null cloud_attrs. No values extracted, shouldn't modify
* message_params. */
nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(NULL, &message_params,
NULL);
tlib_pass_if_null(
"null cloud_attrsnull stream_arn, destination_name should be null.",
"null cloud_attrs and null stream_arn, destination_name should be null.",
message_params.destination_name);

/* Test null message_params but valid stream arn. No values extracted,
* shouldn't modify cloud_attrs. */
nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(VALID_STREAM_ARN, NULL,
&cloud_attrs);
tlib_pass_if_null(
"null stream_arn but valid stream arn, cloud_resource_id should be null.",
"null message_params but valid stream arn, cloud_resource_id should be "
"null.",
cloud_attrs.cloud_resource_id);

/* Test null cloud_attrs but valid stream arn. No values extracted, shouldn't
* modify message_params. */
nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(VALID_STREAM_ARN,
&message_params, NULL);
tlib_pass_if_null(
"null stream_arn but valid stream arn, destination_name should be null.",
"null cloud_attrs but valid stream arn, destination_name should be null.",
message_params.destination_name);

/* Test invalid stream_arns. Output values should be null.*/
nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(
INVALID_STREAM_ARN_1, &message_params, &cloud_attrs);
tlib_pass_if_null("null stream_arn, cloud_resource_id should be null.",
tlib_pass_if_null("invalid stream_arn, cloud_resource_id should be null.",
cloud_attrs.cloud_resource_id);
tlib_pass_if_null("null stream_arn, destination_name should be null.",
tlib_pass_if_null("invalid stream_arn, destination_name should be null.",
message_params.destination_name);

nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(
INVALID_STREAM_ARN_2, &message_params, &cloud_attrs);
tlib_pass_if_null("null stream_arn, cloud_resource_id should be null.",
tlib_pass_if_null("invalid stream_arn, cloud_resource_id should be null.",
cloud_attrs.cloud_resource_id);
tlib_pass_if_null("null stream_arn, destination_name should be null.",
tlib_pass_if_null("invalid stream_arn, destination_name should be null.",
message_params.destination_name);

nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(
INVALID_STREAM_ARN_3, &message_params, &cloud_attrs);
tlib_pass_if_null("null stream_arn, cloud_resource_id should be null.",
tlib_pass_if_null("invalid stream_arn, cloud_resource_id should be null.",
cloud_attrs.cloud_resource_id);
tlib_pass_if_null("null stream_arn, destination_name should be null.",
tlib_pass_if_null("invalid stream_arn, destination_name should be null.",
message_params.destination_name);

nr_lib_aws_sdk_php_kinesis_set_params_from_stream_arn(
INVALID_STREAM_ARN_4, &message_params, &cloud_attrs);
tlib_pass_if_null("null stream_arn, cloud_resource_id should be null.",
tlib_pass_if_null("invalid stream_arn, cloud_resource_id should be null.",
cloud_attrs.cloud_resource_id);
tlib_pass_if_null("null stream_arn, destination_name should be null.",
tlib_pass_if_null("invalid stream_arn, destination_name should be null.",
message_params.destination_name);

/* Test valid stream_arns. Output values should be match.*/
Expand Down
Loading