Skip to content

makedist: Reset tar timestamps to the commit date #13879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2024
Merged

makedist: Reset tar timestamps to the commit date #13879

merged 1 commit into from
Apr 4, 2024

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Apr 3, 2024

This change should make the underlying .tar archive fully reproducible (given identical tool versions).

see #10613
see #10615

@TimWolla
makedist: Reset tar timestamps to the commit date
71e787a 
This change should make the underlying `.tar` archive fully reproducible (given
identical tool versions).
@TimWolla
Copy link
Member Author

TimWolla commented Apr 3, 2024

This change should make the underlying .tar archive fully reproducible (given identical tool versions).

The .tar.gz is still different, because it also includes a timestamp:

├── filetype from file(1)
│ @@ -1 +1 @@
│ -gzip compressed data, was "php-8.3.4.tar", last modified: Wed Apr  3 19:00:36 2024, max compression, from Unix
│ +gzip compressed data, was "php-8.3.4.tar", last modified: Wed Apr  3 19:04:29 2024, max compression, from Unix

@mvorisek
Copy link
Contributor

mvorisek commented Apr 4, 2024

This change should make the underlying .tar archive fully reproducible (given identical tool versions).

The .tar.gz is still different, because it also includes a timestamp:

├── filetype from file(1)
│ @@ -1 +1 @@
│ -gzip compressed data, was "php-8.3.4.tar", last modified: Wed Apr  3 19:00:36 2024, max compression, from Unix
│ +gzip compressed data, was "php-8.3.4.tar", last modified: Wed Apr  3 19:04:29 2024, max compression, from Unix

can that be fixed as well and tested in nightly?

@TimWolla TimWolla merged commit c89d797 into php:PHP-8.2 Apr 4, 2024
8 checks passed
TimWolla added a commit that referenced this pull request Apr 4, 2024
@TimWolla
Merge branch 'PHP-8.2' into PHP-8.3
1fb3836 
* PHP-8.2:
  makedist: Reset tar timestamps to the commit date (#13879)
TimWolla added a commit that referenced this pull request Apr 4, 2024
@TimWolla
Merge branch 'PHP-8.3'
98b43d0 
* PHP-8.3:
  makedist: Reset tar timestamps to the commit date (#13879)
@TimWolla TimWolla deleted the makedist-tar-timestamp branch April 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramsey ramsey ramsey approved these changes

@adoy adoy adoy approved these changes

@bukka bukka bukka approved these changes

@saundefined saundefined saundefined approved these changes

@ericmann ericmann Awaiting requested review from ericmann

Assignees
No one assigned
Labels
Category: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TimWolla @mvorisek @ramsey @adoy @bukka @saundefined