Skip to content

Assert all test files are cleaned up in CI #8977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

iluuu1994
Copy link
Member

Closes GH-8427

@mvorisek
Copy link
Contributor

it should/can target PHP-8.0 as such test expectation is desired there too

@iluuu1994
Copy link
Member Author

Since nightly also runs this validation for each branch, we'll either need to:

  1. Clean up files in those branches too
  2. Just validate this on master

I'll likely opt for 2.

@TimWolla
Copy link
Member

I'll likely opt for 2.

I think this is reasonable. The older branches will naturally rotate out and once they are gone, the check can be enabled for all branches.

@mvorisek
Copy link
Contributor

mvorisek commented Jul 11, 2022

Clean up files in those branches too

I am the author of #8427 and the issue was an issue with ext/mysqli/tests/clean_table.inc in PHP 8.1. And the fix was already merged. I discussed this in the PR desc...

So you can change the target to PHP 8.1, trigger CI, if green, then do the same for PHP-8.0 and if green, merge :)

@Girgias Girgias merged commit b5ab0e0 into php:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants