[#83107] Alias Enumerable#include? to Enumerable#includes? — Alberto Almagro <albertoalmagro@...>

Hello,

9 messages 2017/10/04

[ruby-core:83432] [Ruby trunk Misc#12439][Closed] [PATCH cleanup] process.c (disable_child_handler_fork_child): simplify

From: akr@...
Date: 2017-10-21 07:13:58 UTC
List: ruby-core #83432
Issue #12439 has been updated by akr (Akira Tanaka).

Status changed from Assigned to Closed

It seems already committed.

----------------------------------------
Misc #12439: [PATCH cleanup] process.c (disable_child_handler_fork_child): simplify
https://bugs.ruby-lang.org/issues/12439#change-67400

* Author: normalperson (Eric Wong)
* Status: Closed
* Priority: Normal
* Assignee: akr (Akira Tanaka)
----------------------------------------
process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.


Comments?  Will commit in a week or two if no response.
Thanks.


---Files--------------------------------
0001-process.c-disable_child_handler_fork_child-simplify.patch (3.13 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next